Fix CI failures#4443
Open
mbg wants to merge 6 commits into
Open
Conversation
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve CI instability/timeouts by updating the yauzl dependency (zip extraction), alongside a few TypeScript/module hygiene fixes in the extension codebase.
Changes:
- Bump
yauzlfrom^3.3.0to^3.4.0(and update lockfile). - Switch
tsconfigmodule settings tonodenext/moduleResolution: nodenext. - Tighten/export-split type-only vs value exports and modernize Octokit retry wiring.
Show a summary per file
| File | Description |
|---|---|
| extensions/ql-vscode/tsconfig.json | Switches TypeScript module + resolution to nodenext. |
| extensions/ql-vscode/test/tsconfig.json | Adds Jest typing config and isolatedModules for tests (needs adjustment). |
| extensions/ql-vscode/src/databases/local-databases/index.ts | Splits type-only exports vs value exports for NodeNext/ESM hygiene. |
| extensions/ql-vscode/src/common/octokit.ts | Applies @octokit/plugin-retry via .plugin(retry) instead of config property. |
| extensions/ql-vscode/src/common/mock-gh-api/mock-gh-api-server.ts | Updates MSW type import to the public msw entrypoint. |
| extensions/ql-vscode/package.json | Bumps yauzl version. |
| extensions/ql-vscode/package-lock.json | Lockfile updates for yauzl@3.4.0 and dependency graph changes. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Generated file
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
+8
to
+10
| "rootDir": "..", | ||
| "types": ["jest"], | ||
| "isolatedModules": true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change in this PR is that
yauzlis bumped from3.3.0to3.4.0. That seems to resolve issues with zip extraction getting "stuck" and tests timing out as a result.The other commits are misc. changes to fix issues I encountered while working on the repo locally.