Repository navigation
Handle empty indefinite-length objects in BER2DER - #176
Open
JakeHuneau wants to merge 1 commit into
Open
JakeHuneau wants to merge 1 commit into
JakeHuneau wants to merge 1 commit into
Conversation
readObject read a child object before checking for the end-of-contents octets, so an empty indefinite-length SEQUENCE or SET (30 80 00 00) failed with "Invalid BER format". Check for the terminator before reading each child. Fixes github#103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
readObjectread a child before checking for the end-of-contents octets, so an empty indefinite-length SEQUENCE or SET (30 80 00 00) failed with "Invalid BER format". As suggested in the issue, this checks for the terminator before reading each child. Non-empty objects are handled the same as before.Added
TestBer2Der_EmptyIndefinite, covering an empty SEQUENCE and an empty SET followed by a sibling. Both cases fail without the change.go test -vet=off ./ietf-cms/...passes. (With Go 1.27, vet flags an existing non-constant format string inietf-cms/verify_test.go:257, unrelated to this change.)