Skip to content

Use evals/results and honor Vally results configuration - #14

Merged
ronniegeraghty merged 1 commit into
mainfrom
ronniegeraghty-eval-results-path
Nov 11, 2026
Merged

ronniegeraghty merged 1 commit into
mainfrom
ronniegeraghty-eval-results-path

Conversation

@ronniegeraghty

Copy link
Copy Markdown
Collaborator

What changed

Save native Vally eval output under evals/results/ and have the report helper follow the same project setting instead of independently assuming vally-results/.

  • Set .vally.yaml's paths.results and ignore the new output directory while preserving the legacy ignore.
  • Reuse @microsoft/vally/config to resolve the report's default results directory. Explicit result paths still take precedence, Vally's unconfigured fallback still works, and malformed project configuration is reported instead of silently ignored.
  • Update the existing eval documentation. The native settings writer also wrapped long setup commands; their parsed values and shared marketplace environment are unchanged.

Checks and boundaries

The report tests pass, including configured-vs-legacy selection, the real report CLI, explicit overrides and malformed configuration. Skill/eval lint and diff checks pass.

This is separate from #13's skill/grader fixes and the before/after workflow. No plugin versions, model defaults, sandbox settings or remote pins changed. No paid eval was run and no historical results were moved or committed.

Save native eval output under evals/results and resolve report defaults with Vally's project configuration loader, retaining explicit path overrides and native fallback behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ronniegeraghty
ronniegeraghty requested a review from a team as a code owner November 11, 2026 19:22
Copilot AI auto review requested due to automatic review settings November 11, 2026 19:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the changes aligning eval output and report discovery with project configuration.

No open issues 🎉

What changed in this PR

Aligns saved eval output and report discovery around Vally’s project configuration, using evals/results/ without moving historical results or changing plugin versions.

Changes:

  • Configures and ignores evals/results/ while retaining the legacy ignore.
  • Makes report loading asynchronous and configuration-aware, preserving explicit paths and Vally’s default while surfacing malformed configuration.
  • Adds regression coverage and updates eval documentation.
File Description
docs/​checks-and-evals.md Documents the configured results directory and explicit-path override.
.vally.yaml Sets evals/results and wraps setup commands without changing their behavior.
.gitignore Ignores the new results directory alongside the legacy location.
.github/​scripts/​eval-report.test.mjs Covers configuration, fallback, overrides, CLI behavior, and malformed configuration.
.github/​scripts/​eval-report.mjs Uses Vally configuration for default result discovery and awaits result loading.

Review effort: Balanced (auto)

@ronniegeraghty
ronniegeraghty merged commit faa3e7c into main Nov 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants