Skip to content

Bump basic-ftp from 5.2.2 to removed in the npm_and_yarn group across 1 directory - #131

Merged
francinelucca merged 2 commits into
mainfrom
dependabot/npm_and_yarn/npm_and_yarn-e39e87700b
Nov 20, 2026
Merged

francinelucca merged 2 commits into
mainfrom
dependabot/npm_and_yarn/npm_and_yarn-e39e87700b

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the npm_and_yarn group with 1 update in the / directory: basic-ftp.

Removes basic-ftp

@dependabot
dependabot Bot requested a review from a team as a code owner November 18, 2026 00:39
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Nov 18, 2026
Copilot AI adaptive review requested due to automatic review settings November 18, 2026 00:39
@dependabot dependabot Bot added the javascript Pull requests that update javascript code label Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change has unresolved critical issues: it upgrades the test runner to dependencies requiring Node 22 while workflows still use Node 20, and introduces transitive picomatch versions with an unpatched high-severity vulnerability.

2 open issues
What changed in this PR

This PR removes the transitive basic-ftp dependency by upgrading @web/test-runner and regenerating the npm dependency lockfile; the upgrade also introduces a Node.js 22 requirement while repository workflows still use Node.js 20.

Changes:

  • Upgrades @web/test-runner from 0.18.1 to 1.0.1.
  • Removes basic-ftp and related obsolete transitive dependencies.
  • Refreshes the broader web testing and development dependency tree.
File Description
package.json Updates the direct @web/test-runner development dependency.
package-lock.json Records the upgraded dependency tree and removes basic-ftp.

Review effort: Lite (adaptive)

Comment thread package.json Resolved
Comment thread package.json Resolved
@francinelucca

Copy link
Copy Markdown
Contributor

@copilot address review comments

Copilot AI commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@copilot address review comments

Updated all build and publish workflow Node versions to 22 in 8893d4d and validated with the test suite and build. The picomatch advisory remains unresolved because no patched release is available upstream.

@francinelucca

Copy link
Copy Markdown
Contributor

@copilot updated basic-ftp to v6.2.6 instead of updating test-runner

Copilot AI commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@copilot updated basic-ftp to v6.2.6 instead of updating test-runner

Updated to basic-ftp@6.2.6 via an npm override, restored @web/test-runner@0.18.1, and returned workflows to Node 20. Tests and build pass. Commit: 0f00c7f.

@francinelucca

Copy link
Copy Markdown
Contributor

@dependabot recreate

Bumps the npm_and_yarn group with 1 update in the / directory: [basic-ftp](https://github.com/patrickjuchli/basic-ftp).


Removes `basic-ftp`

---
updated-dependencies:
- dependency-name: basic-ftp
  dependency-version:
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/npm_and_yarn-e39e87700b branch from 0f00c7f to 6074019 Compare November 19, 2026 02:58
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@francinelucca
francinelucca merged commit 02e6a72 into main Nov 20, 2026
6 checks passed
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/npm_and_yarn-e39e87700b branch November 20, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants