Fix lint workflow: drop unresolvable setup-goproxy action - #20
Merged
Merged
Conversation
Every PR fails at job setup: "Unable to resolve action github/setup-goproxy, not found". github/setup-goproxy is private and gh-elm is public, so the workflow cannot resolve it. Not a bad pin; the SHA is still the current v1.1.0. goproxy exists to resolve private github.com/github/* modules. gh-elm has none -- every dependency is public OSS, which is why ci.yml builds and tests the same module graph without it. Drops id-token: write with it, since nothing else needs OIDC. Cherry-picked from 61da97d, stranded on an unmerged feature branch (#13). Co-authored-by: ismith <172694+ismith@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e558d009-3ea1-4455-b1fd-c2a180332509
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The removed action and permission are unnecessary, and the lint dependency path remains valid.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the inaccessible private Go proxy action so the public repository’s lint workflow can run successfully.
Changes:
- Removes unnecessary OIDC permissions and goproxy setup.
- Retains the tag-related cache rationale.
| File | Description |
|---|---|
.github/workflows/lint.yaml |
Simplifies lint setup to use public dependencies directly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hoenn
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every PR in this repo fails
lintat job setup, 3s in, before checkout:Root cause
github/setup-goproxyis not deleted, renamed, or archived — it is alive and maintained (gh api repos/github/setup-goproxyreturns HTTP 200,archived: false, last push 2026-09-25), and the SHA we pin is still the currentv1.1.0. Re-pinning would not help.The actual cause is a visibility mismatch:
github/setup-goproxyis private, andgh-elmis public. A public repository's workflow cannot resolve an action from a private repository in the same org without an explicit access grant. Hence the failure at "Prepare all required actions", before any step runs.Why removing it is the right fix, rather than granting access
goproxy exists to resolve private
github.com/github/*Go modules over OIDC.gh-elmhas none — every dependency is public OSS (charmbracelet/*,spf13/cobra,stretchr/testify,google/uuid,golang.org/x/*,zalando/go-keyring). There are noreplacedirectives, and noGOPRIVATE/GONOSUMDB/GOFLAGSanywhere in the workflows, Makefile orscript/.The clinching evidence:
ci.ymlbuilds, vets and tests the exact same module graph with no goproxy step, and passes. Lint pulls nothing extra —make lintcallsscript/lint-go-code, which callsscript/golangci-lint, which fetches the linter bycurling the public upstream installer, not through a Go module proxy.id-token: writegoes with it, since nothing else in the job needs OIDC.Provenance
This is a cherry-pick of
61da97d(@ismith / copilot-swe-agent, 2026-09-09), which fixed this correctly but is stranded inside the unmerged feature PR #13, so it was not going to reachmainany time soon. Pulled out standalone to unblock the repo.One addition on top of the cherry-pick: it dropped the comment explaining
cache: falsealong with theid-tokenrationale, leaving a bare unexplainedcache: false. Reworded rather than deleted, since the tag-run reason still stands.Verification
make lintpasses locally on the same golangci-lint v2.11.4 the workflow installs — 0 issues. The lint job should now reach that command instead of dying at setup.