-
Notifications
You must be signed in to change notification settings - Fork 504
[q] Switch Daily Storify mined-loop persistence from cache-memory to repo-memory #55394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+175
−13
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0d39c04
Initial plan
Copilot be06b75
Switch daily storify to repo-memory
Copilot 7478f87
Merge origin/main into copilot/switch-daily-storify-to-repo-memory; r…
Copilot f20babb
Resolve merge conflict with main and recompile lock files
Copilot 9c28e1d
Constrain storify repo-memory to its three state files and migrate le…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 79e7d5d.
shared/aw-logs-24h-fetch.mdstill setscache-memory: true, so/tmp/gh-aw/cache-memoryis still restored alongside repo-memory — the legacy state is available at cutover. Added a one-time migration step to the start-up sequence that copies each of the three files from/tmp/gh-aw/cache-memory/storify/only when the repo-memory target is missing, never overwriting an existing repo-memory file. After the first run persists them to the memory branch, the migration is a no-op.Kept this in the workflow's own prompt rather than editing the shared import, since
shared/aw-logs-24h-fetch.mdis consumed by other workflows. Lock file recompiled (the body is runtime-imported, so this shows up as abody_hashchange).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction: the commit is
9c28e1d, not79e7d5d.