Skip to content

Swift: Do not terminate the extractor when a file cannot be opened #22851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 2 commits into from
Oct 21, 2026
Merged

Swift: Do not terminate the extractor when a file cannot be opened #22851

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9582361
Swift: Do not terminate the extractor when a file cannot be opened
jketema Oct 20, 2026
a13a814
Swift: Update comment
jketema Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions swift/extractor/infra/file/TargetFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ bool TargetFile::init() {
checkOutput("open");
return true;
}
CODEQL_ASSERT(errno == EEXIST, "Unable to open {} for writing ({})", targetPath,
CODEQL_EXPECT(errno == EEXIST, "Unable to open {} for writing ({})", targetPath,
currentErrorCode());
// else the file already exists and we just lost the race
// else the file already exists and we just lost the race, or some error occurred
// and the file could not be created
return false;
}

Expand Down
Loading