Repository navigation
Actions: Normalize explicit untrusted checkout paths - #22221
Open
1sgtpepper wants to merge 4 commits into
Open
1sgtpepper wants to merge 4 commits into
1sgtpepper wants to merge 4 commits into
Conversation
1sgtpepper
force-pushed
the
agent/normalize-untrusted-checkout-paths
branch
3 times, most recently
from
July 23, 2026 07:24
4050936 to
857758f
Compare
Author
1sgtpepper
force-pushed
the
agent/normalize-untrusted-checkout-paths
branch
from
July 23, 2026 13:43
483c1f2 to
05933be
Compare
Contributor
|
Although I'm not a big fan of regex (I think we need a proper bash parser. ...and powershell, and batch, and etc.). I have extended the PR here. @1sgtpepper feel free to merge into your PR. |
Author
|
Thanks for digging into this! I’ll wait for Oscar’s take before deciding how much to incorporate. |
Member
|
I think the changes look good, I'm trying to get some Actions experts to review too. Keeping the scope as narrow as possible and iterating on follow ups sounds like the right approach to me, thank you! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
1sgtpepper
force-pushed
the
agent/normalize-untrusted-checkout-paths
branch
from
August 18, 2026 14:11
4b199ee to
f2017b6
Compare
Author
|
@oscarsj Ping when you have a chance, thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22213.
Recognizes scripts and local actions executed from static relative
actions/checkoutpaths in privileged workflows. Canonicalizing both paths before containment checks avoids matching sibling directories or paths that escape the checkout. Dynamic checkout paths retain the existing fallback; workspace-variable and context-expression resolution remain outside this change.Validation: the CWE-829 query suite passed all 8 tests without learning on the PR head and the current-main merge candidate, using CodeQL 2.27.4+202610201846.
git diff --checkpassed.