Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The first argument of the `uri` method of `WebClient$UriSpec` in `org.springframework.web.reactive.function.client` is now considered a request forgery sink. Previously only the first arguments of the `WebClient.create` and `WebClient$Builder.baseUrl` methods were considered. This may lead to more alerts for the query `java/ssrf` (Server-side request forgery).
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ extensions:
data:
- ["org.springframework.web.reactive.function.client", "WebClient", False, "create", "", "", "Argument[0]", "request-forgery", "manual"]
- ["org.springframework.web.reactive.function.client", "WebClient$Builder", False, "baseUrl", "", "", "Argument[0]", "request-forgery", "manual"]
- ["org.springframework.web.reactive.function.client", "WebClient$UriSpec", True, "uri", "", "", "Argument[0]", "request-forgery", "manual"]
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,27 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
// Ignore
}
}

protected void doPut(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
try {
WebClient webClient = WebClient.create("https://example.com");

String p = request.getParameter("uri"); // $ Source
webClient.get()
.uri(p) // $ Alert
.retrieve()
.bodyToMono(String.class)
.block();

String p2 = request.getParameter("uri"); // $ Source
webClient.get()
.uri(java.net.URI.create("https://example.com" + p2)) // $ Alert
.retrieve()
.bodyToMono(String.class)
.block();
} catch (Exception e) {
// Ignore
}
}
}
Loading
Loading