Skip to content

chore(deps-dev): Bump nanoid from 3.3.11 to 3.3.18 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kendallgassner merged 2 commits into from
Sep 9, 2026
Merged

chore(deps-dev): Bump nanoid from 3.3.11 to 3.3.18 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28590b9
chore(deps-dev): Bump nanoid from 3.3.11 to 3.3.18
dependabot[bot] Sep 9, 2026
bbcef87
test: avoid VoiceOver announcement race
kendallgassner Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions tests/guidepup/voiceover.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ if (process.platform === "darwin") {
await page.waitForTimeout(4000);

// Assert that the spoken phrases are as expected
const lastSpokenPhrase = await voiceOver.lastSpokenPhrase();
expect(lastSpokenPhrase.startsWith("a")).toBe(true);
// expect(lastSpokenPhrase.includes("Suggestion: acceptable")).toBe(true); // FIXME: Commenting because this fails, though it _should_ pass.
const spokenPhraseLog = JSON.stringify(await voiceOver.spokenPhraseLog());
expect(spokenPhraseLog.includes("a")).toBe(true);
// expect(spokenPhraseLog.includes("Suggestion: acceptable")).toBe(true); // FIXME: Commenting because this fails, though it _should_ pass.
expect(
lastSpokenPhrase.includes("Press right arrow to commit suggestion")
spokenPhraseLog.includes("Press right arrow to commit suggestion")
).toBe(true);
});
} else {
Expand Down