Repository navigation
Fix issue 67 - #117
Merged
pushpam2404 merged 1 commit intoOct 8, 2026
Merged
Fix issue 67#117
Conversation
prmanna78-source
requested review from
Prashansure and
pushpam2404
as code owners
October 8, 2026 04:05
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on your first pull request to this repository.
Here is what happens next:
- The check below runs only the file you changed and needs it to print
All checks passed!. If it is red, click Details — it shows the same error you would see by running the file yourself - A maintainer reviews within 48 hours and may leave line comments
- Once it is approved, a maintainer merges it
Two things that get PRs closed, so please double-check:
- No
Closes #<issue>in the description - The issue was never assigned to you
Nice work getting this far. Most people never open their first PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this fix?
Closes #67
Which file did you change?
python-open-source-challenge/issue-67.py
What was wrong, and what did you change?
The program was checking whether the marks decreased instead of increased in every successive test. I changed the comparison so that each mark must be greater than the previous mark. I also added a check to handle students with fewer than two tests.
Terminal output