Repository navigation
Respect NO_COLOR in the auto color mode - #170
Merged
Merged
Conversation
Closed
peso
approved these changes
Nov 22, 2026
Collaborator
|
Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
The
autocolor mode, which is also the default, now prints no colors whenNO_COLORis set to a non-empty value, as https://no-color.org/ describes.--color alwaysstill prints colors, since a command line option overrides the variable.auto_color()holds the old auto check plus theNO_COLORcheck, and both auto paths use it.--colorhelp,docs/manual.mdand the CHANGELOG mention it.Checked with the built binary in a pseudo terminal (
script):NO_COLOR=1gives no escape codes by default and with--color auto,NO_COLOR=(empty) keeps colors, andNO_COLOR=1 --color alwayskeeps colors.cargo fmt --check,cargo clippy --all --all-targetsandcargo test --allpass.