fix(replacer): log HTTP driver exception chains - #8378
Closed
sentry-junior[bot] wants to merge 4 commits into
Closed
fix(replacer): log HTTP driver exception chains#8378sentry-junior[bot] wants to merge 4 commits into
sentry-junior[bot] wants to merge 4 commits into
Conversation
clickhouse-connect only emits "Unexpected Http Driver Exception" without the urllib3/socket cause, and snuba's LOG_FORMAT drops multi-line tracebacks in Cloud Logging. Fold the cause chain into one-line errors on the ClickHouse client and replacer paths so we can see timeouts vs connection resets. Co-Authored-By: PDPM <pierre.massat@sentry.io>
phacops
marked this pull request as ready for review
August 22, 2026 02:38
Co-Authored-By: PDPM <pierre.massat@sentry.io>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c99c5e. Configure here.
run_query sits under ShardedExecutor retries and query-node fallback. ERROR there made recoverable replica failures look fatal. Keep the single-line crash log in flush_batch after retries are exhausted. Co-Authored-By: PDPM <pierre.massat@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
errors-replacerdies with:and nothing useful after that.
Two reasons the real failure is invisible:
clickhouse-connectlogsUnexpected Http Driver Exceptionwithout the urllib3/socket cause.LOG_FORMATis%(asctime)s %(message)s, so arroyo'slogger.exceptiontraceback often never shows up in Cloud Logging.What
OperationalError/StreamFailureError).ClickhouseError.flush_batch(after retries/fallback), with type/project/host.run_query: that path is retried byShardedExecutorand can fall back to the query node.This does not fix the slow shard / timeout root cause. It only makes the next crash tell us whether we hit
ReadTimeout, connection reset, protocol error, etc.Test plan
tests/clickhouse/test_connect.pycovers chain formatting + driver/stream error loggingClickHouse HTTP driver error ... detail=... | caused by: ...Requested by PDPM.
--
View Junior Session in Sentry