ref(seer): Drop transitional failedChecks names field from overview API - #122490
Draft
NicoHinderling wants to merge 1 commit into
Draft
ref(seer): Drop transitional failedChecks names field from overview API#122490NicoHinderling wants to merge 1 commit into
NicoHinderling wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
Contributor
Sentry Snapshot Testing
|
NicoHinderling
force-pushed
the
nico/ref/seer-overview-drop-failed-checks-names
branch
from
August 24, 2026 17:44
2a14037 to
b6bb02d
Compare
NicoHinderling
force-pushed
the
nico/feat/seer-overview-failing-check-run-urls
branch
from
August 24, 2026 17:53
f985830 to
643ff03
Compare
NicoHinderling
force-pushed
the
nico/ref/seer-overview-drop-failed-checks-names
branch
from
August 24, 2026 17:54
b6bb02d to
ae26f56
Compare
NicoHinderling
force-pushed
the
nico/feat/seer-overview-failing-check-run-urls
branch
from
August 24, 2026 17:59
643ff03 to
c3a6043
Compare
NicoHinderling
force-pushed
the
nico/ref/seer-overview-drop-failed-checks-names
branch
from
August 24, 2026 18:00
ae26f56 to
5199b97
Compare
mtopo27
approved these changes
Aug 24, 2026
Base automatically changed from
nico/feat/seer-overview-failing-check-run-urls
to
master
August 24, 2026 19:20
The autofix overview API carried both failedChecks (names only) and failedCheckDetails (name + run link). failedChecks existed solely so the pre-links frontend kept working across the split deploy. Now that the frontend reads failedCheckDetails, drop the redundant field and its TypedDict entry so the endpoint has one representation of failing checks.
NicoHinderling
force-pushed
the
nico/ref/seer-overview-drop-failed-checks-names
branch
from
August 24, 2026 19:23
5199b97 to
7e3267b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge until the frontend (#122489) is deployed.
This removes the
failedChecksfield that the currently-deployed frontend still reads. It is only safe once #122489 (which readsfailedCheckDetails) has shipped everywhere.Summary
Follow-up cleanup for the failing-check run-links work (#122486, now merged). The overview API temporarily carried both
failedChecks(names only) andfailedCheckDetails(name + run link);failedChecksexisted solely to keep the pre-links frontend working across the non-atomic deploy. Now that the frontend readsfailedCheckDetails, this drops the redundant field and itsPullRequestPayloadTypedDict entry, leaving one representation of failing checks.Deploy order
feat(seer): Add failing check run URLs to autofix overview API #122486 (backend, adds— mergedfailedCheckDetails)failedCheckDetails) — merge + deployTests
Updates the overview endpoint tests to assert
failedChecksis no longer in the payload and onlyfailedCheckDetailsis present.