fix(workflow-engine): harden level condition label rendering - #122488
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
fix(workflow-engine): harden level condition label rendering#122488sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Unknown match values like `ne` KeyError'd while serializing rules. Fall back to the raw value and restrict level schema to supported ops. Fixes SENTRY-5TFR
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing project rules 500s when a level filter has an unsupported match op such as
ne(NOT_EQUAL). Level only evaluateseq/gte/lte, butrender_labelused a strict dict lookup and the comparison schema allowed everyMatchType.Changes
NOT_EQUAL.Why
GET /api/0/projects/.../rules/serializes every rule label. One bad stored match value should not take down the whole list.Fixes SENTRY-5TFR
--
View Junior Session [Sentry]