fix(dashboards): format negative bytes in metrics charts - #122476
Merged
lzhao-sentry merged 3 commits intoAug 24, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nsdeschenes
approved these changes
Aug 24, 2026
nsdeschenes
left a comment
nsdeschenes
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
Though, wondering if it would be worth it to handle this in the underlying formatter, rather than applying it around it 🤔
lzhao-sentry
changed the title
nsdeschenes
approved these changes
Aug 24, 2026
lzhao-sentry
deleted the
lzhao/fix/format-negative-values-metrics-chart
branch
August 24, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is to address DAIN-1824
Instead of updating the many places the formatter is used, update the formatters themselves to handle negative bytes. Also added some unit tests for the formatters
Before Change
After Change