Skip to content

fix(trace): Hide span-only metrics from trace waterfall tab - #122474

Open
nsdeschenes wants to merge 4 commits into
masterfrom
nd/EXP-1153/fix-trace-waterfall-hide-application-metrics-tab
Open

fix(trace): Hide span-only metrics from trace waterfall tab#122474
nsdeschenes wants to merge 4 commits into
masterfrom
nd/EXP-1153/fix-trace-waterfall-hide-application-metrics-tab

Conversation

@nsdeschenes

@nsdeschenes nsdeschenes commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • exclude span-sourced metrics from trace-details metric availability and counts
  • use the filtered count for tab visibility, header metadata, empty traces, and project discovery
  • keep span-sourced metrics out of the Application Metrics samples and autocomplete queries
  • preserve metrics with no source attribute or any source other than span

Closes EXP-1153

@linear-code

linear-code Bot commented Aug 24, 2026

Copy link
Copy Markdown

EXP-1153

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 24, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 14d2802. Configure here.

Comment thread static/app/views/performance/newTraceDetails/traceMetrics.tsx Outdated
Comment thread static/app/views/performance/newTraceDetails/traceMetrics.tsx
@nsdeschenes
nsdeschenes marked this pull request as ready for review August 24, 2026 18:42
@nsdeschenes
nsdeschenes requested a review from a team as a code owner August 24, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant