fix(project-creation): Preserve SCM details on platform change - #122470
Open
jaydgoss wants to merge 8 commits into
Open
fix(project-creation): Preserve SCM details on platform change#122470jaydgoss wants to merge 8 commits into
jaydgoss wants to merge 8 commits into
Conversation
Keep user-selected teams and manually edited project names when the SCM platform changes. Continue updating untouched project names from the platform default. Fixes VDY-183
github-actions
Bot
added
the
Scope: Frontend
Use one compatibility rule when changing platforms and saving the SCM wizard. This keeps sessions from before the flag from losing their explicit project name after an unchanged return. Refs VDY-183
The host no longer clears the whole form on a platform change; it only resets an untouched name. Update the derivation comment's example to match.
A restored session with wasNameManuallyModified: false is the one case where the persisted flag overrides the legacy explicit-name fallback. Pin that a platform change after the return re-derives the name and keeps the team.
Name the platform-change reset condition positively (shouldResetName) and replace the mixed ?? / !== expression in isProjectNameManuallyModified with explicit early returns. No behavior change.
The test retypes a name identical to the derived default, which reads as an accident. Comment the two phases and the deliberate identical retype: manual detection must come from the edit flag, not a value-vs-default comparison.
…m test Retyping the derived default made the manual-edit phase invisible in the field. Type 'my-app' instead, so the preserved value can only come from the manual edit.
Select framework SDKs (Django/React) in the platform-change test so picks commit straight from the picker instead of detouring through the framework-suggestion modal, and assert the derived name before the switch so the re-derivation reads as a change.
scttcper
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Keep SCM project names and team selections when users change platforms. Untouched project names still follow the selected platform default.
Details
ScmPlatformFeaturesCorepreviously cleared the entire project-details form on every platform selection. The project creation host now resets only an unmodified platform-derived name and preserves the selected team, alert settings, and manual names. It also persists whether the name was manually edited so the behavior remains stable after returning from getting-started.Fixes VDY-183