fix(inbox): Show retry CTA when Seer produces no code changes - #122464
Draft
roggenkemper wants to merge 4 commits into
Draft
fix(inbox): Show retry CTA when Seer produces no code changes#122464roggenkemper wants to merge 4 commits into
roggenkemper wants to merge 4 commits into
Conversation
The next-step helper returns `create_pr` as soon as the code changes step completes, even when the run produced no diff, so the inbox preview showed "Create PR" for a run with nothing to open a PR from. Check the completed section for patches and fall back to "Add context & retry", matching the autofix panel on issue detail.
github-actions
Bot
added
the
Scope: Frontend
Hoist the code changes retry state into IssuePreview so the action row's "Add context & retry" CTA opens the reset prompt the proposal section already renders, rather than navigating to the Seer drawer to reach it. The proposal section keeps owning that state when rendered without the enclosing provider. Extract the shared patch lookup as getCodeChangePatches so the action row and the proposal section can't drift.
Carry a one-time drawer action from the empty-code-changes CTA so the Seer context form is ready immediately. Refs ISWF-3280
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-jle0ahoze.sentry.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Seer completes the code changes step without producing a diff, the inbox preview still showed a "Create PR" CTA — there is nothing to open a PR from.
The action row now checks the completed code changes section for patches and, when there are none, renders "Add context & retry" instead. Clicking it opens the reset prompt the proposal section already renders inline (next to "No code changes were proposed."), so the retry happens in the preview rather than navigating to the Seer drawer.
To share that state,
IssuePreviewhoists the code changes retry context above both the action row and the Seer content; the proposal section still owns it when rendered without that provider. The patch lookup both call sites need is nowgetCodeChangePatchesinuseExplorerAutofix.Fixes ISWF-3280