Repository navigation
chore(ruby): Remove unused Configuration error tracking - #3164
Merged
sl0thentr0py merged 2 commits intoOct 29, 2026
Merged
Conversation
Its last caller was removed in #1601 when the transport stopped checking sending_allowed?. The method is @api private and nothing in the monorepo calls it.
With error_messages gone, nothing reads @errors outside of specs. Drop the private errors reader and the helpers that only existed to populate it, which also stops sending_to_dsn_allowed? from mutating state on every call. Co-Authored-By: Neel Shah <6536764+sl0thentr0py@users.noreply.github.com>
sentry-junior
Bot
changed the title
sl0thentr0py
approved these changes
Oct 29, 2026
sl0thentr0py
deleted the
chore/remove-unused-configuration-error-messages
branch
October 29, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly cleanup: removes
Sentry::Configuration#error_messagesand the@errorstracking that only existed to feed it.What's removed
Configuration#error_messages(@api private). Its last caller was the transport's "Envelope not sent: ..." debug log, which was removed in Avoid duplicated sampling on Transaction events #1601 (Nov 2021).errorsreader (@!visibility private), the@errorsarray, and the privatevalid?/capture_in_environment?helpers that only existed to append messages to it.sending_to_dsn_allowed?now just returns!!@dsn&.valid? && enabled_in_current_env?.errorscontents. Thesending_allowed?true/false assertions next to them stay.Why it's safe
error_messagesis gone, nothing in the monorepo readserrors/@errorsexcept those spec assertions (git grepacross all gems, specs, and docs).sending_to_dsn_allowed?returns the same boolean as before. It also stops resetting and mutating@errorsevery time it's called.No CHANGELOG entry, because
AGENTS.mdsays the changelog is generated during release.via @sl0thentr0py.
--
View Junior Session [Sentry]