Skip to content

test(vernier): Cleanup stop_profile properly #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sl0thentr0py merged 1 commit into from
Oct 28, 2026
Merged

test(vernier): Cleanup stop_profile properly #3163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions sentry-ruby/spec/sentry/vernier/profiler_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
end
end

after do
Vernier.stop_profile if Vernier.instance_variable_get(:@collector)
end
Comment thread
sl0thentr0py marked this conversation as resolved.

let(:profiles_sample_rate) { 1.0 }
let(:traces_sample_rate) { 1.0 }

Expand Down Expand Up @@ -147,7 +151,7 @@
it 'stops Vernier if sampled and started' do
profiler.set_initial_sample_decision(true)
profiler.start
expect(Vernier).to receive(:stop_profile)
expect(Vernier).to receive(:stop_profile).and_call_original
profiler.stop
end

Expand All @@ -161,7 +165,10 @@
it 'does not crash when stopping Vernier crashed' do
profiler.set_initial_sample_decision(true)
profiler.start
expect(Vernier).to receive(:stop_profile).and_raise(RuntimeError.new("Profile not started"))
expect(Vernier).to receive(:stop_profile).and_wrap_original do |stop_profile|
stop_profile.call
raise RuntimeError.new("Profile not started")
end
profiler.stop
end
end
Expand Down
Loading