Skip to content

fix: https support spotlight transport - #3136

Merged
sl0thentr0py merged 2 commits into
getsentry:masterfrom
sandstrom:copilot/fix-https-support-spotlight-transport
Oct 28, 2026
Merged

sl0thentr0py merged 2 commits into
getsentry:masterfrom
sandstrom:copilot/fix-https-support-spotlight-transport

Conversation

@sandstrom

Copy link
Copy Markdown

Description

Add support for HTTPs in spotlight transport. Useful when running spotlight in docker container or behind proxy for example.

# this now works
config.spotlight = "https://spotlight.example:9443/stream"

Fixes: #3128

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 707aed3. Configure here.

Comment thread sentry-ruby/lib/sentry/transport/spotlight_transport.rb

@sl0thentr0py sl0thentr0py left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @sandstrom !

@sandstrom

Copy link
Copy Markdown
Author

@sl0thentr0py Thanks!

Do you take it from here?

The error seems unrelated to my code, so nothing I can do about it afaik.

Job 122186246485 failed during Ruby environment setup, not during tests.

The jdx/mise-action installation failed because it could not find precompiled Ruby builds for x86_64_linux for four requested versions:

    Ruby 3.1
    Ruby 3.0
    Ruby 2.7
    JRuby 9.4.14.0

@sl0thentr0py

Copy link
Copy Markdown
Member

yes I'll take it from here, just CI stuff

Copilot AI and others added 2 commits October 28, 2026 14:43
Co-authored-by: sandstrom <122287+sandstrom@users.noreply.github.com>
@sl0thentr0py
sl0thentr0py force-pushed the copilot/fix-https-support-spotlight-transport branch from 707aed3 to 2c1b84c Compare October 28, 2026 13:44
@sl0thentr0py
sl0thentr0py merged commit 8118156 into getsentry:master Oct 28, 2026
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support HTTPS in Spotlight transport

3 participants