Repository navigation
chore(deps): Bump getsentry/craft from 2.35.0 to 3.5.0 - #6983
Merged
Merged
Conversation
Update the Craft action pin in the release workflow to the 3.5.0 commit. Remove the craft_version input. Craft 2.x could not get its CLI version from a SHA ref, so the workflow had to repeat the version. In Craft 3.x the action resolves the CLI version from the pinned commit and makes sure that the tag and the published binary match it. This keeps the CLI and the action in sync. Dependabot PR #6980 updated only the pin, so it left the CLI at 2.35.0.
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR updates the
getsentry/craftaction in the release workflow from 2.35.0 to 3.5.0. It also removes thecraft_versioninput. In Craft 3.x, the action gets the CLI version from the pinned commit, so the CLI always matches the pin.💡 Motivation and Context
This PR replaces #6980. In #6980, Dependabot updated only the action pin and left
craft_version: 2.35.0, so the release job would install the old CLI.💚 How did you test it?
I ran the Craft
resolve-craft-version.shscript for the pinned commit withoutcraft_version, and it returned3.5.0. I also checked that the 3.5.0 tag points to that commit and that the release has acraftbinary.📝 Checklist
sendDefaultPIIis enabled.