Skip to content

chore(deps): bump getsentry/craft from 2.35.0 to 3.5.0 #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
+1 −1
Closed

chore(deps): bump getsentry/craft from 2.35.0 to 3.5.0 #6980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
cache-dependency-path: yarn.lock

- name: Prepare release
uses: getsentry/craft@7a7857552e2cdc08b502de96e6076849c01fba32 # v2.35.0
uses: getsentry/craft@3f1f02d50b08b8c509a28d2cc2abf594e9a28011 # v3.5.0

Check warning on line 46 in .github/workflows/release.yml

View check run for this annotation

@sentry/warden / warden: code-review

craft_version remains at 2.35.0 after the Craft bump 

Update `craft_version` to `3.5.0` so it matches the pinned Craft action version. The workflow comment says this value must match the SHA tag; leaving it at `2.35.0` means the workflow still selects the old Craft version.

Check warning on line 46 in .github/workflows/release.yml

View check run for this annotation

@sentry/warden / warden: find-bugs

`craft_version` remains stale after the action bump 

The release step pins `getsentry/craft` to the v3.5.0 SHA but still passes `craft_version: 2.35.0`. The workflow comment says Craft cannot derive its version from a SHA ref and this value must match the SHA tag, so the step is configured with the old Craft version. Update `craft_version` to `3.5.0`.
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Expand Down
Loading