Skip to content

ref(boto3): Rename span origin to auto.aws.boto3 - #8034

Merged
pabloDeputter merged 3 commits into
major/3.0from
pablo/boto3-aws-origin
Oct 15, 2026
Merged

pabloDeputter merged 3 commits into
major/3.0from
pablo/boto3-aws-origin

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

Rename the boto3 span origin from auto.http.boto3 to auto.aws.boto3, for every boto3 span including the streamed response body child, and removes the unused get_span_origin() method from _ServiceExtension.
(todo: to be added to migration guide if we change it)

Why

  1. auto.http.boto3 describes the underlying transport/integration used; boto3 spans are AWS API calls, and (in the future) the ops will be changed from http.client => rpc, db, queue.*, object.*, so it doesn't really fit anymore.
  2. JS does the same and uses auto.aws.aws_sdk.

Other option

The other option is to use auto.rpc.boto3 as the default origin (since aws isn't technically part of the categories, even though JS uses it https://develop.sentry.dev/sdk/telemetry/traces/trace-origin/) and override it with the span's op for different services:

  • db => auto.db.boto3
  • queue.* => auto.queue.boto3
  • object.* => auto.object.boto3
  • streamed body child has op http.client.stream => auto.http.boto3

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 14, 2026 16:00
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 14, 2026 16:00
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 56199 passed | ❌ 1 failed | ⏭️ 2872 skipped | Total: 59072 | Pass Rate: 95.14% | Execution Time: 156m 31s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -81870
Passed Tests 📉 -77467
Failed Tests 📈 +1
Skipped Tests 📉 -4404

✅ Patch coverage is 100.00% (1 of 1 changed executable lines covered; target 80%).
Project statement coverage is 90.07% (down 0.16 percentage points from base (6c430fb) to head (26d789e)).

Changed files with executable lines (1)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/consts.py 100.00% 1/1 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8034       +/-##
==========================================
- Coverage    90.23%    90.07%    -0.16%
==========================================
  Files          202       193        -9
  Tracked lines     26660     20932     -5728
  Branches      9926      7206     -2720
==========================================
- Hits         24055     18854     -5201
+ Misses        2605      2078      -527
+ Partials      1510      1233      -277

Generated by Coverage Action

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to MIGRATION_GUIDE.md 🙏🏻

@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-aws-origin branch from 52b2be0 to f39c4d1 Compare October 15, 2026 13:43
@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-aws-origin branch from f39c4d1 to 1e7111f Compare October 15, 2026 13:48

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1e7111f. Configure here.

Comment thread sentry_sdk/integrations/boto3/_instrumentation.py Outdated
@pabloDeputter
pabloDeputter merged commit 774ea06 into major/3.0 Oct 15, 2026
148 of 149 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/boto3-aws-origin branch October 15, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants