fix: Fail loudly when the in-app SDK internals move - #144
Merged
Conversation
StackTraceProcessor read SentryOptions.InAppInclude / InAppExclude and the StringOrRegex fields via reflection and silently ignored a miss. Resolve them once, warn (rethrow under SentryPowershellRethrowErrors), and pin them in sdk-internals.tests.ps1 next to the transport internals. Follow-up to the review on #143. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @jamescrosswell's review on #143.
Problem
StackTraceProcessorreadsSentryOptions.InAppInclude/InAppExcludeand theStringOrRegexvalue fields through reflection. A miss on the properties silently disabled the options; a miss on the fields threw a null-method error on every event.Approach
SentryPowershellRethrowErrors(set in tests) it rethrows, matching the context-line handling in the same class.tests/sdk-internals.tests.ps1, next to the transport internals. The existingStringOrRegexfield check moves there.Public, so the code keeps working if sentry-dotnet makes these members public.Tested against the bundled 6.10.0. The recent sentry-dotnet change to
StringOrRegex(getsentry/sentry-dotnet#5543) only addsIsRegex; the fields are unchanged.🤖 Generated with Claude Code