Skip to content

test(external-reporter): verify consent revoked blocks reporter launch on inproc/breakpad/native - #1935

Open
d2anamaria wants to merge 3 commits into
masterfrom
test/consent-revoked-inproc-breakpad
Open

test(external-reporter): verify consent revoked blocks reporter launch on inproc/breakpad/native#1935
d2anamaria wants to merge 3 commits into
masterfrom
test/consent-revoked-inproc-breakpad

Conversation

@d2anamaria

Copy link
Copy Markdown
Contributor
  • Add inproc/breakpad tests for consent-revoked with cache-keep blocking external reporter upload
  • Add no-cache discard tests for inproc/breakpad and native when consent is revoked
  • Add consent-give flush tests for cached crash envelopes with crash-reporter enabled
  • Extend native external-reporter consent coverage beyond the test shipped in fix(consent): honor checks before launching crash reporter #1906

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 719cd30. Configure here.

)

assert len(httpserver.log) == 0
assert not cache_dir.exists() or len(list(cache_dir.glob("*.envelope"))) == 0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Race in native no-cache consent test

Medium Severity

test_native_external_crash_reporter_consent_revoked_no_cache asserts an empty cache and no HTTP upload right after run_crash returns, without waiting for the native daemon. Daemon crash handling is asynchronous, so those checks can pass before discard or upload finishes. The existing no-cache native pattern uses wait_for_daemon=True for this reason.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 719cd30. Configure here.

@d2anamaria
d2anamaria marked this pull request as draft July 31, 2026 12:18
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.75%. Comparing base (5bac907) to head (719cd30).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
+ Coverage   75.74%   75.75%   +0.01%     
==========================================
  Files          93       93              
  Lines       22128    22128              
  Branches     3939     3939              
==========================================
+ Hits        16760    16763       +3     
+ Misses       4484     4479       -5     
- Partials      884      886       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d2anamaria
d2anamaria marked this pull request as ready for review July 31, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant