Repository navigation
fix(server-utils): Record Anthropic chat spans for thread and tool-runner streams on 1.2+ - #25931
Open
RulaKhaled wants to merge 3 commits into
Open
RulaKhaled wants to merge 3 commits into
RulaKhaled wants to merge 3 commits into
Conversation
Contributor
size-limit report 📦Compared: 331f9fb (PR test merge using develop at 8a102ea) Against: 8a102ea (develop) · base run #64990 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 51 successful. See the run.
Successful checks
|
RulaKhaled
force-pushed
the
fix/anthropic-1x-thread-chat-spans
branch
2 times, most recently
from
November 2, 2026 14:30
b953034 to
4198705
Compare
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit aedfeab. Configure here.
RulaKhaled
marked this pull request as ready for review
November 2, 2026 15:06
RulaKhaled
requested review from
andreiborza,
isaacs and
nicohrubec
and removed request for
a team
November 2, 2026 15:06
RulaKhaled
requested review from
Lms24,
logaretm and
s1gr1d
and removed request for
a team
November 4, 2026 13:35
…nner streams on 1.2+
On @anthropic-ai/sdk 1.2.0+, streamed turns from
beta.messages.toolRunner({ stream: true }) and beta.messages.thread().stream()
had no gen_ai.chat spans. The thread parses the response of each create() call
through a new APIPromise our hook never sees, so the span never ended. Hook
BetaMessageStream._start(), match each request to its stream by abort signal,
and end the span from the stream's events.
instrumentMessageStream now also ends the span on 'end', so aborted or truncated
streams no longer leave it open.
Fixes #25816
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A later create() sent with a finished thread stream's signal was wired to that stream and its span never ended. Drop the entry once an attempt succeeds, since only rejected attempts are retried. Also cover the 'end' listener with a unit test and update the wrapStreamResult JSDoc. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Each mode and turn is now its own test.each case, with no conditionals, so a failure points at one path. The cases share one scenario run per env, since every run is a Node process. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
RulaKhaled
force-pushed
the
fix/anthropic-1x-thread-chat-spans
branch
from
November 4, 2026 13:36
de27780 to
7fe1266
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
@anthropic-ai/sdk1.2.0+, streamed turns frombeta.messages.toolRunner({ stream: true })andbeta.messages.thread().stream()had nogen_ai.chatspans. Every tool runner runs over a thread since 1.2.0, including on Bedrock and Vertex.The thread calls
beta.messages.create(), which opens our span, but parses the response through a newAPIPromiseour hook never sees, so the span never ended. This hooksBetaMessageStream._start(), matches each request to its stream by abort signal, and ends the span from the stream's events with usage and output.instrumentMessageStreamnow also ends the span onend, so aborted or truncated streams,messages.stream()included, no longer leave it open. An abort before the response is not marked as an error.Stacked on #25750.
Fixes #25816
🤖 Generated with Claude Code