Repository navigation
fix(server-utils): Use onlyIfParent for Firestore spans - #25877
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 29, 2026 13:05
nicohrubec
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
mydea
and removed request for
a team
October 29, 2026 13:05
andreiborza
approved these changes
Oct 29, 2026
Contributor
size-limit report 📦Compared: 8652a5f (PR test merge using develop at 1e3ef41) Against: 1e3ef41 (develop) · base run #64120 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5a65879. Configure here.
nicohrubec
enabled auto-merge (squash)
October 29, 2026 13:08
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 53 successful. See the run.
Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Consolidating to use the core
onlyIfParentlogic everywhere so we can get rid ofrequiresParentSpan.