Repository navigation
ref(cloudflare): Simplify shared SDK initialization - #25864
Merged
nicohrubec merged 1 commit intoOct 29, 2026
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
Contributor
size-limit report 📦Compared: 3fc766a (PR test merge using develop at eaa9997) Against: eaa9997 (develop) · base run #64063 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 32 successful. See the run. Successful checks
|
nicohrubec
marked this pull request as ready for review
October 29, 2026 08:34
nicohrubec
requested review from
a team,
JPeer264,
andreiborza and
mydea
and removed request for
a team
October 29, 2026 08:35
mydea
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The main SDK and
/requestalready use the same default integrations, so passing a callback to select the default integrations is no longer necessary. This PR simplifies the setup.How to review: Both entry points now share
initBaseSdk()and the same default integrations. Check thatsdk.tsstill handles optional OpenTelemetry setup, while/requestimports only the base initializer and never reachessdk.ts. Existing module-graph and OpenTelemetry tests cover this boundary.supersedes #25853
closes #24039