Repository navigation
fix(server-utils): Require a parent span for Firestore operations - #25855
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dc25c18 to
5f6dcbf
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@lazerg we'll review this, as well as other PRs but to be very clear: We do not appreciate "contribution farming" and opening 7 PRs in a row without once asking if we're fine with you taking over those changes. Our contribution guidelines clearly tell external contributors to ask a maintainer first. An unfortunate change we had to make given that writing code no longer costs time, but reviewing agent-written code is the painful part now. Please keep this in mind for the next contribution. Thank you. |
Add a Node E2E check next to the Deno test: a Firestore call outside any active span must not produce a root db.query span. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c854344. Configure here.
Flush before the marker span so an unparented Firestore span would reach the proxy first, and assert on all spans of a dedicated collection instead of only root spans. A parented call inside the marker proves the instrumentation is active. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #25855 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>

Why: Firestore calls made outside any active span each became their own root span with no context. This passes
requiresParentSpan: trueto the channel binding, like the other db integrations.How to review: The fix is the option in
firebase/instrumentation.ts. The Deno test runsaddDocbefore, inside and after a parent span and checks that only the one inside creates a span.Closes #25800