Repository navigation
feat(bundler-plugins): Enable hidden source maps and remove them after upload in the Rollup plugin - #25645
Draft
timfish wants to merge 1 commit into
Conversation
timfish
added this pull request to stack #25649
October 22, 2026 10:47
Contributor
size-limit report 📦Compared: b506034 (PR test merge using develop at 9da2ac0) Against: 8042719 (develop) · base run #63102
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 22, 2026 10:57
aaa1a70 to
02c2650
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 failing, 63 successful. See the run.
Successful checks
|
…r upload in the Rollup plugin When the Rollup or Rolldown output has no `sourcemap` setting and an upload can run, the plugin switches the output to hidden source maps, copies each chunk and its map into the upload staging folder from `generateBundle`, and drops the map asset so it is never written. `deleteSourcemapsAfterUpload: true` does the same for maps the user enabled. The framework SDKs pass `deleteSourcemapsAfterUpload: false` so their builds do not change.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 22, 2026 11:49
02c2650 to
d86c896
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the stack for #25609. When the Rollup or Rolldown output has no
sourcemapsetting and an upload can run, the plugin switches the output to hidden source maps, copies each chunk and its map into the upload staging folder from agenerateBundlehook that runs last, and drops the map asset so it is never written.deleteSourcemapsAfterUpload: truedoes the same for maps the user enabled; a chunk the plugin cannot prepare keeps its map, with a warning.The framework SDKs pass
deleteSourcemapsAfterUpload: false, so their builds do not change until each one migrates in its own PR.