Repository navigation
Conversation
mydea
changed the title
Contributor
size-limit report 📦Compared: 42ba635 (PR test merge using develop at 6df508e) Against: 6df508e (develop) · base run #63271 ✅ Baseline matches: this diff contains only this PR's changes.
|
mydea
marked this pull request as ready for review
October 21, 2026 11:35
mydea
requested review from
Lms24,
andreiborza,
isaacs and
logaretm
and removed request for
a team
October 21, 2026 11:35
mydea
added a commit
that referenced
this pull request
Oct 22, 2026
The `.diagnostic_channel` suffix on span origins was left over from v10,
where it distinguished these spans from the OTel-based ones. The rest of
the v11 origins already dropped mechanism parts like `.otel` and
`.orchestrion`.
- `auto.graphql.diagnostic_channel` → `auto.graphql.graphql`: graphql
has a single instrumentation path, so the suffix carried no information.
The integration name stays, as in every other
`auto.<category>.<integration>` origin.
- `auto.db.{redis,mysql2,mongoose}.diagnostic_channel` →
`auto.db.{redis,mysql2,mongoose}.native_channel`: these integrations
still have two paths, the library's own tracing channels (newer
versions) and orchestrion-injected channels (older versions, plain
`auto.db.<lib>`). `native_channel` says what the distinction actually
is.
While at it, two origins that were inconsistent with their siblings:
- `auto.http.wintercg_fetch` → `auto.http.fetch`: Bun, Deno and
Cloudflare already use `auto.http.fetch` for the same instrumentation.
- `auto.grpc.serverless` → `auto.grpc.google_cloud`: `serverless` didn't
name the integration.
Spec violations (category, part count) are handled separately in #25602.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ref/span-origin-spec-violations
branch
from
October 22, 2026 07:11
79f052c to
6945fb7
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 59 successful. See the run.
Successful checks
|
Lms24
approved these changes
Oct 22, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Nice cleanup, thanks! One open question regarding ai vs. gen_ai but otherwise LGTM!
| - `SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN` (`'sentry.origin'`) with a proper span origin | ||
| - a proper origin must only contain [a-z], [A-Z], [0-9], `_` and `.` characters. | ||
| - a proper origin has at most four parts, `<type>.<category>.<integration_name>.<integration_part>`, and must not skip a part. `type` is `auto` or `manual`. | ||
| - `category` must be a span op category (e.g. `http`, `db`, `queue`, `function`, `ai`, `ui`, `rpc`), matching the span's op. Flag origins that put a library or vendor in the category slot (e.g. `auto.kafkajs.producer` instead of `auto.queue.kafkajs.producer`). |
Member
There was a problem hiding this comment.
Suggested change
| - `category` must be a span op category (e.g. `http`, `db`, `queue`, `function`, `ai`, `ui`, `rpc`), matching the span's op. Flag origins that put a library or vendor in the category slot (e.g. `auto.kafkajs.producer` instead of `auto.queue.kafkajs.producer`). | |
| - `category` must be a span op category (e.g. `http`, `db`, `queue`, `function`, `gen_ai`, `ui`, `rpc`), matching the span's op. Flag origins that put a library or vendor in the category slot (e.g. `auto.kafkajs.producer` instead of `auto.queue.kafkajs.producer`). |
| attributes: expect.objectContaining({ | ||
| 'sentry.op': { type: 'string', value: 'gen_ai.invoke_agent' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.vercelai.channel' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.ai.vercelai' }, |
Member
There was a problem hiding this comment.
l/m: if we want to double down on the "the second part must be a span op category", this should be
Suggested change
| 'sentry.origin': { type: 'string', value: 'auto.ai.vercelai' }, | |
| 'sentry.origin': { type: 'string', value: 'auto.gen_ai.vercelai' }, |
Member
Author
There was a problem hiding this comment.
this is a good point, but we use auto.ai.* a lot right now 😬 maybe something for a follow up, but likely this should be aligned across all ai things then!
Member
There was a problem hiding this comment.
yup totally fine with a follow up or fwiw with leaving these slightly unaligned to the op all together. My suspicion is, we added the origin back when those ops were still called ai.* and when we changed the ops to gen_ai we didn't change the origin.
logaretm
previously approved these changes
Oct 22, 2026
logaretm
self-requested a review
October 22, 2026 18:01
logaretm
reviewed
Oct 22, 2026
|
|
||
| /** The span origin every aws-sdk channel span carries. */ | ||
| export const AWS_SDK_ORIGIN = 'auto.aws.aws_sdk'; | ||
| export const AWS_SDK_ORIGIN = 'auto.rpc.aws_sdk'; |
Member
There was a problem hiding this comment.
A DynamoDB span gets op db but origin auto.rpc.aws_sdk. If the origin category should match the op, that span should be auto.db.aws_sdk, SQS/SNS auto.queue.aws_sdk, and Bedrock auto.ai.aws_sdk.
| attributes: { | ||
| [SENTRY_OP]: FUNCTION_AWS, | ||
| [SENTRY_ORIGIN]: 'auto.aws_lambda', | ||
| [SENTRY_ORIGIN]: 'auto.function.aws_lambda', |
Member
There was a problem hiding this comment.
Should this be auto.function.aws_serverless? The errors from this same handler already use aws_serverless as the name.
mydea
force-pushed
the
ref/span-origin-spec-violations
branch
from
October 23, 2026 06:41
6945fb7 to
555944a
Compare
Use a span op category as the second origin part, keep origins at most
four parts, and stop encoding the instrumentation mechanism:
- auto.amqplib.* -> auto.queue.amqplib.*
- auto.kafkajs.* -> auto.queue.kafkajs.*
- auto.vercelai.channel -> auto.ai.vercelai
- auto.firebase.firestore -> auto.db.firebase.firestore
- auto.firebase.functions -> auto.function.firebase
- auto.aws.aws_sdk -> auto.rpc.aws_sdk
- auto.aws_lambda -> auto.function.aws_lambda
- auto.mcp.notification -> auto.function.mcp_server.notification
- auto.db.cloudflare.durable_object.sql -> auto.db.cloudflare.durable_object_sql
- auto.http.browser.{lcp,cls,inp} -> auto.ui.browser.{lcp,cls,inp}
Also spell out the origin rules in AGENTS.md and BUGBOT.md so new
origins follow them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nism types Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ref/span-origin-spec-violations
branch
from
October 23, 2026 09:15
b740dfb to
cb9535a
Compare
mydea
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several span origins didn't follow the trace origin spec (
<type>.<category>.<integration_name>.<integration_part>, wherecategoryis a span op category). Most put the library in the category slot, which makes it impossible to group origins by category the way ops are grouped. v11 is already renaming origins (#22722, #23627), so this is the window to fix them.auto.amqplib.{publisher,consumer}auto.queue.amqplib.{publisher,consumer}auto.kafkajs.{producer,consumer}auto.queue.kafkajs.{producer,consumer}auto.vercelai.channelauto.ai.vercelai(matches the otherauto.ai.<provider>origins)auto.firebase.firestoreauto.db.firebase.firestoreauto.firebase.functionsauto.function.firebaseauto.aws.aws_sdkauto.{rpc,db,queue,ai}.aws_sdk(category follows the span op: DynamoDBdb, SQS/SNSqueue, Bedrockai, otherwiserpc)auto.aws_lambdaauto.function.aws_serverless(matches the existingauto.function.aws_serverless.*mechanism types)auto.mcp.notificationauto.function.mcp_server.notification(sits next toauto.function.mcp_server)auto.db.cloudflare.durable_object.sqlauto.db.cloudflare.durable_object_sql(was five parts)auto.http.browser.{lcp,cls,inp}auto.ui.browser.{lcp,cls,inp}(web vital spans, opui.webvital.*)The Vercel AI exception mechanism type moves along with its origin. AGENTS.md and BUGBOT.md now spell out the category and four-part rules so new origins are checked against them.
🤖 Generated with Claude Code