Repository navigation
test(nextjs): Warm the module graph before the tunnel route tests - #25593
Merged
nicohrubec merged 1 commit intoOct 21, 2026
Conversation
The first test in `getFinalConfigObjectUtils.test.ts` paid for the cold transform of the module and its dependency tree. On a slow CI runner this took more than the 5 second test timeout. Vitest does not stop a timed-out test, so its late `console.log` went into the next test's spy, and two tests failed. A `beforeAll` hook now imports the module once. `vi.resetModules()` clears the module registry but keeps the transform cache, so later imports are fast. The slow work runs in the hook, which has its own timeout and cannot leak into a test. A longer test timeout would also pass, but a slow first test could still break the next one. Fixes #25591 Fixes JS-3977 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
requested review from
chargome and
s1gr1d
and removed request for
a team
October 21, 2026 02:06
nicohrubec
deleted the
isaacschlueter/js-3977-flaky-test-maybesetuptunnelrouterewriterules-times-out-on
branch
October 21, 2026 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first test in
getFinalConfigObjectUtils.test.tspaid for the cold transform of the module and its dependency tree. On a slow CI runner this took more than the 5 second test timeout. Vitest does not stop a timed-out test, so its lateconsole.logwent into the next test's spy, and two tests failed.A
beforeAllhook now imports the module once.vi.resetModules()clears the module registry but keeps the transform cache, so later imports are fast. The slow work runs in the hook, which has its own timeout and cannot leak into a test.A longer test timeout would also pass, but a slow first test could still break the next one.
Fixes #25591
Fixes JS-3977