Repository navigation
fix(node): Use the request method for Hapi routes with multiple methods - #25527
Merged
s1gr1d merged 7 commits intoOct 23, 2026
Conversation
Contributor
size-limit report 📦Compared: 2926f60 (PR test merge using develop at e1026aa) Against: 6def2d7 (develop) · base run #63362
|
Co-authored-by: Rahul Kashyap <itisrmk@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…53-hapi-routemethodtouppercase-is-not-a-function-for-routes # Conflicts: # CHANGELOG.md
This was referenced Oct 19, 2026
andreiborza
approved these changes
Oct 21, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
LGTM, could you already create the conventions PR too?
…53-hapi-routemethodtouppercase-is-not-a-function-for-routes # Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`server.ext.type` is deprecated in the Sentry conventions in favor of `hapi.ext.type`. Send both until v12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
s1gr1d
requested review from
chargome and
logaretm
and removed request for
a team
October 23, 2026 13:12
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 64 successful. See the run.
Successful checks
|
…53-hapi-routemethodtouppercase-is-not-a-function-for-routes # Conflicts: # CHANGELOG.md
s1gr1d
deleted the
sigridhuemer/js-3953-hapi-routemethodtouppercase-is-not-a-function-for-routes
branch
October 23, 2026 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hapi routes registered with several methods (
method: ['GET', 'POST']) returned a 500 withtraceLifecycle: 'static'. Router spans now use the request method. This also fixes*as the method on wildcard routes.The Hapi attributes (
hapi.type,hapi.plugin.name,server.ext.type) are not in the Sentry conventions yet.Fixes #25481