Repository navigation
test(e2e): Inherit root Volta config in all e2e test apps - #25369
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under Node >= 24.13 the SDK injects instrumentation via Module.registerHooks, which tsx's CJS loader bypasses. Keep the pin until #25351 lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 14, 2026 15:55
s1gr1d
approved these changes
Oct 14, 2026
Member
There was a problem hiding this comment.
Nice! Two notes:
- #25334 removes all
volta.pnpmpins, including the nuxt-5 ones (because you mentioned the nuxt-5 app in the description) - For future pins, I'd use
devEngines.runtimeinstead of using Volta here: pnpm 12 downloads that Node version itself, andsetup-nodealso looks at this field
JPeer264
approved these changes
Oct 14, 2026
Member
Author
can we inherit this too? This is actually IMHO a very useful feature of volta, that we can keep this in sync for these e2e tests without duplicating it everywhere (as basically this PR shows exactly how easy it is to mess this up/misalign this when done manually 😅) |
Member
Author
My understanding after reviewing those cases was mostly that those needed a newer version than 20, which is why we pinned it, not that we wanted to test 22 specifically! |
51 tasks done
renovate Bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Oct 17, 2026
| datasource | package | from | to | | ---------- | ------------------- | ----- | ------ | | npm | @sentry/vite-plugin | 5.4.1 | 11.8.0 | ## [v11.8.0](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#1180) ##### Important Changes - **feat(bundler-plugins): Release `@sentry/webpack-plugin`, `@sentry/vite-plugin`, `@sentry/rollup-plugin` and `@sentry/esbuild-plugin` from the SDK repository ([#25095](getsentry/sentry-javascript#25095 The four standalone bundler plugins now release together with the SDK, so their version jumps from 5.4.1 to the SDK version. Each package re-exports the matching `@sentry/bundler-plugins` entry point, which we recommend for new projects. The plugin options do not change, but the update brings these breaking changes: - Node.js 20.19.0 or higher is required. - `@sentry/webpack-plugin` requires webpack 5.1 or higher. The `@sentry/webpack-plugin/webpack5` entry point still works and exports the same plugin as `@sentry/webpack-plugin`. - The plugins use the `sentry` CLI SDK instead of `@sentry/cli`. Sentry self-hosted 26.4.2 or higher is supported. Lower versions may continue to work. - Deploys that the plugins create on Vercel use the value of `VERCEL_TARGET_ENV` (`production`, `preview` or a custom name) as their environment, instead of `vercel-production` or `vercel-preview`. To keep the old value, set `release.deploy.env`. - **feat(server-utils): Instrument the OpenAI decisions API as `gen_ai.decide` spans ([#25285](getsentry/sentry-javascript#25285 OpenAI `decisions.create` calls now create `gen_ai.decide` spans. ##### Other Changes - feat(core): Support SuppressedError in LinkedErrors integration ([#25246](getsentry/sentry-javascript#25246)) - fix(astro): Delete generated source maps for static output ([#25310](getsentry/sentry-javascript#25310)) - fix(astro): Upload source maps of Astro 7's prerender build ([#25309](getsentry/sentry-javascript#25309)) - fix(browser): Apply `urlQueryParams` to the Referer header ([#25324](getsentry/sentry-javascript#25324)) - fix(cloudflare): auto-instrument when wrangler `main` is a package ([#25343](getsentry/sentry-javascript#25343)) - fix(hono): Expose runtime-specific SDK options ([#25290](getsentry/sentry-javascript#25290)) - fix(node): Instrument Prisma 8 CollectionBase from rc.15 ([#25301](getsentry/sentry-javascript#25301)) - fix(nuxt): Skip 3xx/4xx Nuxt errors in the vue:error hook ([#25341](getsentry/sentry-javascript#25341)) - fix(server-utils): Read pi-durable 1.2.0 tool results from `output` ([#25312](getsentry/sentry-javascript#25312)) - fix(server-utils): Transform modules once when two Sentry Vite plugins add orchestrion ([#25043](getsentry/sentry-javascript#25043)) - fix(sveltekit): add op and origin to Kit's `sveltekit.endpoint` span ([#25376](getsentry/sentry-javascript#25376)) - fix(tanstackstart-react): Keep parametrized route names in Nitro 3 builds ([#25307](getsentry/sentry-javascript#25307)) - fix(tanstackstart-react): Rewrite source paths of split route modules ([#25361](getsentry/sentry-javascript#25361)) <details> <summary> <strong>Internal Changes</strong> </summary> - chore: Add external contributor to CHANGELOG.md ([#25375](getsentry/sentry-javascript#25375)) - ci: Install the pnpm version that Volta pins ([#25287](getsentry/sentry-javascript#25287)) - license: Add cli FSL notice to package licenses ([#25314](getsentry/sentry-javascript#25314)) - ref(core): use shared MCP attribute conventions ([#25059](getsentry/sentry-javascript#25059)) - ref(tanstackstart-react): Reuse shared component annotation options ([#25313](getsentry/sentry-javascript#25313)) - test(browser): Keep whitespace text out of the handlers-lcp page ([#25280](getsentry/sentry-javascript#25280)) - test(bun): Restore [@sentry/core](https://github.com/sentry/core) spies after the Bun.serve tests ([#25276](getsentry/sentry-javascript#25276)) - test(bundler-plugins): Disable CLI telemetry in the CLI contract tests ([#25308](getsentry/sentry-javascript#25308)) - test(e2e): Add node-openai-decisions-send-to-sentry test app ([#25331](getsentry/sentry-javascript#25331)) - test(e2e): Add node-openai-send-to-sentry test app ([#24824](getsentry/sentry-javascript#24824)) - test(e2e): Add nuxt-5-sourcemaps test ([#25268](getsentry/sentry-javascript#25268)) - test(e2e): Inherit root Volta config in all e2e test apps ([#25369](getsentry/sentry-javascript#25369)) - test(e2e): Use an external host address for the Lambda DSN on loopback hostnames ([#25282](getsentry/sentry-javascript#25282)) - test(nextjs): Run nextjs-16-tunnel on Cloudflare ([#25161](getsentry/sentry-javascript#25161)) - test(nextjs): Switch DEBUG_BUILD with a getter instead of re-importing the SDK ([#25279](getsentry/sentry-javascript#25279)) - test(node): Await the child exit in the "should exit" integration tests ([#25277](getsentry/sentry-javascript#25277)) - test(node): Cover ioredis v6 in the diagnostics_channel suite ([#25300](getsentry/sentry-javascript#25300)) - test(node): Cover LangChain model calls made from a tool without config ([#25326](getsentry/sentry-javascript#25326)) - test(node): Log slow and failed Docker Compose starts in integration tests ([#25278](getsentry/sentry-javascript#25278)) - test(node): Unflake captureMessage with_level test ([#25358](getsentry/sentry-javascript#25358)) - test(sveltekit): Pin rollup to 4.64.5 ([#25328](getsentry/sentry-javascript#25328)) </details> Work in this release was contributed by [@kunal649](https://github.com/kunal649) and [@mketiku](https://github.com/mketiku). Thank you for your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most e2e apps that pinned their own Node version did so to run on something newer than the old Node 20 base. Since #24343 moved the root to Node 24.21.0, those pins are either redundant or now older than the root (e.g. the
24.15.0pins), so every app now simply extends the root Volta config.This also drops the Node 20 pin that #24343 added to
react-send-to-sentryas a stopgap, since it passes on Node 24 now.Two overrides remain:
11.10.0innuxt-5andnuxt-5-sourcemaps, which was bumped deliberately in test(e2e): Enable nuxt-5 as optional #22017.20.19.5intsx-express. On Node >= 24.13 the SDK injects instrumentation throughModule.registerHooks, whoseloadhook tsx's CJS loader bypasses (it replacesModule._extensionsand calls_compiledirectly), so Express is never instrumented. fix(node): restore tsx runtime instrumentation #25351 fixes this; the pin can go once it lands.🤖 Generated with Claude Code