Repository navigation
fix(react): Match React Router navigations against root routes only - #25336
Open
JoshuaKGoldberg wants to merge 4 commits into
Open
JoshuaKGoldberg wants to merge 4 commits into
JoshuaKGoldberg wants to merge 4 commits into
Conversation
logaretm
approved these changes
Oct 13, 2026
JoshuaKGoldberg
marked this pull request as ready for review
October 13, 2026 19:05
JoshuaKGoldberg
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 13, 2026 19:05
…deDescendantRoute
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combination of:
allRoutes: holding every nested route alongside its ancestorsmatchRoutes: flattening each entry's children again...results in the React Router integration matching against far more branches than the router itself on every navigation. That includes query-only changes (~90ms per interaction on sentry.io).
Fix: matching only root routes cuts most of that cost and names navigations after the route the router actually renders, instead of sometimes picking a nested route matched on its own.
matchRoutesflattens per call/explore/metrics//issues/:groupId/events//settings/projects/:projectId/keys//explore/traces/trace/:traceSlug/handleNavigationper click in the app (dev build, Chrome trace)Repro using the SDK, under Node with jsdom
Fixes #25340.