Repository navigation
fix(cloudflare): Export session APIs - #25330
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: Codex <codex@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d14df9a. Configure here.
| captureFeedback, | ||
| startSession, | ||
| captureSession, | ||
| endSession, |
There was a problem hiding this comment.
Missing test for session exports
Low Severity
This fix PR exports startSession, captureSession, and endSession but adds no test that would fail without those exports. The review rules require a unit, integration, or E2E test covering the regression. This was flagged because it was mentioned in the review rules.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit d14df9a. Configure here.
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Generally fine but did anyone ask for this? If not, maybe we can hold off a bit from merging this. I'm currently talking to a few people if we should continue sending session health data from backend SDKs, or if we should rather sunset this feature since tracking sessions in the backend is a bit "weird".
|
@Lms24 ah wasn't aware. noone asked for this I was just working on the docs and noticed that cloudflare is the only API that doesn't export this so wanted to consolidate. I'll close for now! |
yeah this only came up yesterday/today, so you couldn't have known. Good and bad timing in a way 😅 |
|
yeah 😅 thanks for the heads up! |
2 participants
Export
startSession,captureSession, andendSessionfrom@sentry/cloudflare, matching the other server SDKs. The existing core implementations also become available through@sentry/hono/cloudflare.Refs SDK-1531.