Repository navigation
test(node-integration): Stop exporting NODE_VERSION and RUNTIME from the test utils - #25292
Merged
Merged
Conversation
…rom the test utils
Suites limit tests to a Node version or a runtime with `supports`, so the
raw values stay private to the test utils. The last suite that checked
`NODE_VERSION` itself now uses `test.runIf(supports({ min: 24 }))`, which
skips the same Node versions. A Bugbot rule flags suites that check the
Node version or the runtime in other ways.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lms24
approved these changes
Oct 12, 2026
JPeer264
marked this pull request as ready for review
October 12, 2026 13:43
JPeer264
requested review from
isaacs and
mydea
and removed request for
a team
October 12, 2026 13:43
JPeer264
enabled auto-merge (squash)
October 12, 2026 13:44
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #25202
This stops exporting
NODE_VERSIONandRUNTIMEfrom the Node integration test utils, so suites limit tests withtest.runIf(supports({ ... })). It movesthread-blocked-native, the last suite that checkedNODE_VERSIONitself, tosupports, and adds a Bugbot rule that flags suites that check the Node version or the runtime in other ways, for example withprocess.versions.