Repository navigation
test(e2e): Add nuxt-5-sourcemaps test - #25268
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
s1gr1d
requested review from
mydea and
nicohrubec
and removed request for
a team
October 12, 2026 12:13
nicohrubec
approved these changes
Oct 13, 2026
| return debugIds; | ||
| } | ||
|
|
||
| // TODO: The uploader passes the emitted file paths to `glob` as patterns, so it skips a file whose path has glob |
Member
There was a problem hiding this comment.
are there any issues tracking these?
Member
Author
There was a problem hiding this comment.
Not yet, I created them now as sub-issues of this one: #25319
I'll link them in the TODOs.
s1gr1d
added a commit
that referenced
this pull request
Oct 13, 2026
Some E2E apps need a different pnpm version than the root. The `install-pnpm` action now reads `volta.pnpm` with the same lookup the E2E runner uses for overrides. Apps keep their versions, and no workflow hard-codes pnpm anymore. The test `nuxt-5` uses pnpm 11, because pnpm 9.15.9 hangs while installing Nuxt 5 nightlies (fixed issue in #22017). pnpm 9 also rejects these apps' `pnpm-workspace.yaml` (`packages field missing or empty`). CI chose 11.10.0 only for the exact name `nuxt-5`, so `nuxt-5-sourcemaps` (#25268) got 9.15.9 and failed. The canary job ignored app pins entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of
nuxt-4-sourcemapsfor Nuxt 5 (Nitro 3), set up likenuxt-5: it uses the nightly builds and runs as an optional app.It differs from the Nuxt 4 test in two places:
.output/public. So the check that every client debug ID was uploaded runs only when the maps are kept.sourcesContent..vuefiles.Merge after this is merged: #25267 and #25287 (CI fix)