Repository navigation
feat(bundler-plugins): Move individual bundler plugin packages - #25095
Conversation
…sbuild plugins Move the four wrapper packages from sentry-javascript-bundler-plugins into packages/legacy. Each one re-exports the matching @sentry/bundler-plugins subpath and now releases in lockstep with the SDK.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
size-limit report 📦
|
There was a problem hiding this comment.
We should add a changelog entry that this release bumps the four packages from 5.4.1 to 11.6.0 (?) and what the breaking changes are. I believe mostly just that the new minimum self hosted version requirement is now higher. I don't think anything else is breaking but if there is, let's include it as well in the changelog.
EDIT: Also the min Node version is now 20.19.0
EDIT 2: webpack min version is now 5.1.0 (I think)
As for the concrete self-hosted version, this is a bit weird because no one seems to know which self-hosted version the new CLI actually requires as a minimum. For v11, we added [26.4.2(https://docs.sentry.io/platforms/javascript/migration/v10-to-v11/#:~:text=Version%2011%20of%20the%20SDK%20requires%20Sentry%20self%2Dhosted%2026.4.2%20or%20higher) as the minimum version. AFAIK, the CLI team said the actual minimum is some 25.x version but not which one 🙃 Let me get back on the exact version.
There was a problem hiding this comment.
This just reminded me: did we migrate the options documentation for the new packages? Right now, I think https://www.npmjs.com/package/@sentry/vite-plugin is the only place where all plugin options are documented. Unless we already took care of this when we added @sentry/bundler-plugins to the repo?
If not, I'd say the cheapest thing we can do is add the options table to the readme of the legacy and probably also of the new package. WDYT?
…r-plugin-packages # Conflicts: # CHANGELOG.md
Also move the changelog entry back under Unreleased.
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
I understand the intention of moving the packages into a legacy sub dir, but IMHO this creates the need for more changes than if we just add them like regular packages.
For example, if we stick with the sub dir, we need to further adjust
CACHED_DEPEDNENCY_PATHSincanary.ymlclean:depspackage.json script
I'd slightly tend towards setting them like regular packages, just to reduce a bit of complexity. Also allows us to get rid of a couple of extra changes. WDYT?
There was a problem hiding this comment.
FYI/Note to myself: just talked to @JPeer264 and we'll include a special note in all plugin packages LICENSE files about the new sentry CLI package not being MIT licensed. Currently this is only on the main repo's LICENSE, so we'll do this in one go, after merging this PR.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e18de3. Configure here.
…r-plugin-packages
Also move the changelog entry back under Unreleased.
…r-plugin-packages
2 participants
Move the four wrapper packages from
sentry-javascript-bundler-pluginsintopackages/legacy. Each one re-exports the matching@sentry/bundler-pluginssubpath and now releases in lockstep with the SDK.