feat(ember): Set url.template, url.path and url.full on router spans#22095
Open
Lms24 wants to merge 1 commit into
Open
feat(ember): Set url.template, url.path and url.full on router spans#22095Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
Lms24
requested review from
chargome,
mydea and
s1gr1d
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ff5adcc to
be1c420
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
aa52df6 to
45fa82b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
be1c420 to
ff5adcc
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
45fa82b to
659f478
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ff5adcc to
be1c420
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
659f478 to
45fa82b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
be1c420 to
ff5adcc
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
45fa82b to
659f478
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ff5adcc to
a40f18b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
659f478 to
610bc80
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 610bc80. Configure here.
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
610bc80 to
cfee70c
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
6265a7c to
ffde4cb
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
6a4e140 to
afa64b0
Compare
s1gr1d
approved these changes
Jul 8, 2026
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ffde4cb to
c2ee1fa
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
afa64b0 to
b3c7a17
Compare
Emit standard URL attributes on Ember pageload and navigation root spans, updating navigation attributes at routeDidChange once the destination URL is finalized. Co-Authored-By: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
feat/pageload-url-attrs-ember
branch
from
b3c7a17 to
219838a
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
c2ee1fa to
a020c02
Compare
| attributes: { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.ember', | ||
| ..._getRouteUrlAttributes(url, routeInfo.params), |
Contributor
There was a problem hiding this comment.
Bug: The result of routerService.recognize(url) can be null, but its properties are accessed without a null check, which could cause a TypeError during instrumentation.
Severity: MEDIUM
Suggested Fix
Add a null check for the routeInfo object after calling routerService.recognize(url). If routeInfo is null, provide a fallback or default value for the route name and parameters to prevent a TypeError when starting the span.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts#L154
Potential issue: The `routerService.recognize(url)` method can return `null` if the
provided URL does not match any known routes, which can occur in misconfigured
applications or with unusual URL formats. The code accesses `routeInfo.name` and the
newly added `routeInfo.params` without first checking if the `routeInfo` object is null.
This will lead to a `TypeError` and crash the page load instrumentation when an
unrecognized URL is encountered.
Also affects:
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts:217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit
url.template,url.path, andurl.fullon Ember pageload and navigation root spans so Ember aligns with the other framework router instrumentations in this stack.Navigation spans set URL attributes at
routeDidChangeviarouterService.currentURL, once the destination route is finalized. Dynamic path segments are parameterized intourl.template(e.g./users/123→/users/:user_id).E2E coverage was added for both
ember-classicandember-embroider, plus unit tests for the URL attribute helpers.Stacked on #22091.