feat(solid): Set url attributes on solid router and tanstack router spans#22090
Open
Lms24 wants to merge 1 commit into
Open
feat(solid): Set url attributes on solid router and tanstack router spans#22090Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
e595d12 to
d6abd79
Compare
a518d21 to
1d77c34
Compare
d6abd79 to
ee4514c
Compare
1d77c34 to
6c98bbb
Compare
6c98bbb to
6190c45
Compare
ee4514c to
0002c1f
Compare
6190c45 to
6c98bbb
Compare
0002c1f to
ee4514c
Compare
6c98bbb to
6190c45
Compare
ee4514c to
0002c1f
Compare
0002c1f to
ee4514c
Compare
6190c45 to
6c98bbb
Compare
ee4514c to
b276e49
Compare
8d16900 to
3aea408
Compare
a6eb9e5 to
d262ae6
Compare
3aea408 to
377e8a8
Compare
377e8a8 to
eed2188
Compare
d262ae6 to
1442f98
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eed2188. Configure here.
…pans Adds url.template, url.path, and url.full to pageload and navigation spans for Solid Router and TanStack Solid Router, including redirect and back-button navigation cases. Updates solidstart and solid-tanstack-router e2e tests. part of #21921 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1442f98 to
fe7157e
Compare
eed2188 to
cc1771f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
url.template,url.path, andurl.fullto pageload and navigation spans for Solid Router and TanStack Solid Router integrations, including redirect and back-button navigation cases.Ports
locationToSpanUrlAttributesfrom the React TanStack Router integration and updates Solid Router to pass the destination URL when starting navigation spans. Includes e2e test coverage for solidstart and solid-tanstack-router.part of #21921
Made with Cursor