Conversation
Disable profiling when profilesSampler throws instead of applying the static profilesSampleRate or inheriting a parent profiling decision. Preserve trace sampling metadata and normal null-result fallback. Cover static-rate bypass, parent inheritance, and failures in both samplers without changing existing catch types. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
This was referenced Sep 24, 2026
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Callback Errors)
📜 Description
Disable profiling when
profilesSamplerthrows, without changing trace sampling. Skip the configuredprofilesSampleRateand do not inherit a parent's profiling decision after callback failure.The parent path preserves the trace sampling decision, trace sample rate, and sample-random value, including backfilling when needed. It does not mutate the original parent decision. A callback deliberately returning
nullstill uses the existing fallback behavior. Error logging and catch types are unchanged.If
tracesSampleralso throws, the failure behavior from #6163 disables both tracing and profiling regardless of the parent's decision. Its immediatecallback_errorreports and accepted duplicate sampling-loss reports remain unchanged.💡 Motivation and Context
A failed profiling callback must not enable profiling through a static rate or parent inheritance. Returning the parent's entire sampling decision would bypass the local failure result and could re-enable profiling, so the failure path retains only the parent's trace fields.
💚 How did you test it?
./gradlew spotlessApply apiDumpTracesSamplerTest,ScopesTest, OpenTelemetrySentrySamplerTest, and the core API check successfully.null.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Profile discard accounting is handled separately in #6166. Profile/replay artifact cleanup remains a follow-up. The broader callback-boundary catch-type changes remain deferred to the next major.