Skip to content

ref(metrics): Deprecate MetricsUnit in favor of MeasurementUnit #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
runningcode wants to merge 3 commits into from
Closed

ref(metrics): Deprecate MetricsUnit in favor of MeasurementUnit #6086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c9d5d
ref(metrics): Deprecate MetricsUnit in favor of MeasurementUnit
runningcode Sep 10, 2026
7e57086
changelog
runningcode Sep 10, 2026
84086b5
ref(metrics): Pass MeasurementUnit through apiName instead of new ove…
runningcode Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Internal

- Deprecate `MetricsUnit` in favor of `MeasurementUnit`, which defines the same units; pass them to the `Sentry.metrics()` API as `MeasurementUnit.Duration.MILLISECOND.apiName()` ([#6086](https://github.com/getsentry/sentry-java/pull/6086))

## 8.56.0

### Behavioral Changes
Expand Down
10 changes: 7 additions & 3 deletions ...sentry-samples-spring-7/src/main/java/io/sentry/samples/spring7/web/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring7.web;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...g-boot-4-opentelemetry/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...pring-boot-4-otlp/src/main/java/io/sentry/samples/spring/boot4/otlp/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot4.otlp;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -22,14 +22,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...-spring-boot-4-webflux/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...-samples-spring-boot-4/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...lemetry-noagent/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...a-opentelemetry/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...ng-boot-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...t-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...ring-boot-opentelemetry/src/main/java/io/sentry/samples/spring/boot/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
10 changes: 7 additions & 3 deletions ...webflux-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.MeasurementUnit;
import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -24,14 +24,18 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
Sentry.metrics()
.gauge("memory.free", value.doubleValue(), MeasurementUnit.Information.BYTE.apiName());
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
.distribution(
"distributionMetric",
value.doubleValue(),
MeasurementUnit.Duration.MILLISECOND.apiName());
return "distribution metric tracked";
}
}
Loading
Loading