test: Verify Java 8 API compatibility coverage#5747
Draft
adinauer wants to merge 1 commit into
Draft
Conversation
📲 Install BuildsAndroid
|
0229500 to
305dafe
Compare
e4d6027 to
53c091c
Compare
Intentionally introduce Java 8-incompatible JDK API references across existing and newly covered JVM integration modules. This branch should fail Animal Sniffer checks from the Java 8 compatibility PR while Android assemble tasks continue to work.
53c091c to
dcf938e
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 29117d4 | 315.09 ms | 353.43 ms | 38.34 ms |
| e122d12 | 360.71 ms | 433.96 ms | 73.25 ms |
| 609df4f | 315.04 ms | 360.96 ms | 45.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 29117d4 | 0 B | 0 B | 0 B |
| e122d12 | 0 B | 0 B | 0 B |
| 609df4f | 0 B | 0 B | 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Intentionally introduce Java 8-incompatible JDK API references across several JVM integration modules.
This PR is a validation PR for #5745 and is expected to fail the Animal Sniffer checks wired into
check.Intentional violations:
:sentry-logback:Objects.requireNonNullElse(Object, Object):sentry-jul:Objects.requireNonNullElse(Object, Object):sentry-apache-http-client-5:Objects.requireNonNullElse(Object, Object):sentry-okhttp:Objects.requireNonNullElse(Object, Object)This covers both modules that already had Animal Sniffer and modules that #5745 newly configures. The core
:sentryviolation was intentionally removed so the normalchecklifecycle reaches non-core module failures in CI.💡 Motivation and Context
This verifies the Java 8 runtime API compatibility coverage added in #5745 catches newer JDK API references across multiple JVM SDK integration modules while leaving Android builds unaffected.
💚 How did you test it?
Normal
checkfails in a non-core module once the core violation is removed:Focused
--continuerun confirms all intentional non-core violations are caught:Android still assembles:
Formatting/API generation still passes:
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Close this PR after confirming the workflow fails as expected.
#skip-changelog