fix(anr): Detect main thread from tombstone via pid matching thread id#5742
Open
markushi wants to merge 7 commits into
Open
fix(anr): Detect main thread from tombstone via pid matching thread id#5742markushi wants to merge 7 commits into
markushi wants to merge 7 commits into
Conversation
On Linux/Android the main thread's kernel thread id always equals the process id, so match a tombstone thread whose id equals the pid as the main thread and normalize its name back to "main". This is more robust than relying on the OS-assigned thread name, which some versions/OEMs replace with the process name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4c04bb8 | 350.71 ms | 413.63 ms | 62.92 ms |
| bb0ff41 | 315.84 ms | 350.76 ms | 34.92 ms |
| 7c1a728 | 289.46 ms | 368.15 ms | 78.69 ms |
| ff8eea4 | 313.42 ms | 337.08 ms | 23.66 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| 91bb874 | 311.00 ms | 363.47 ms | 52.47 ms |
| abfcc92 | 337.38 ms | 427.39 ms | 90.00 ms |
| ae7fed0 | 293.84 ms | 380.22 ms | 86.38 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| d15471f | 307.28 ms | 381.85 ms | 74.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4c04bb8 | 0 B | 0 B | 0 B |
| bb0ff41 | 0 B | 0 B | 0 B |
| 7c1a728 | 0 B | 0 B | 0 B |
| ff8eea4 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| ae7fed0 | 1.58 MiB | 2.12 MiB | 551.77 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
markushi
requested review from
0xadam-brown,
adinauer,
romtsn and
runningcode
as code owners
romtsn
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Analogous to the ANR thread-dump fix in #5733, applied it to the tombstone (
ApplicationExitInfonative crash) path as well.Changes
"main".No public API change.
💡 Motivation and Context
When the OS names the main thread after the process (or leaves it unnamed), native crashes were not attributed to the main thread. Matching on
id == pidis robust and does not depend on the (truncatable) process name.💚 How did you test it?
TombstoneParserTestcovering main-thread detection and name normalization, with separate crashed/background threads to verify independence.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps