* collection: extend app start
* changelog
* feat(extend-app-start): [1/4] Add IAppStartExtender bridge (#5605)
* feat(extend-app-start): Add IAppStartExtender bridge and SentryOptions wiring
Introduces the @ApiStatus.Internal IAppStartExtender contract (extendAppStart /
finishAppStart / getExtendedAppStartSpan) and a NoOp default, wired into
SentryOptions. This is the naming-stable core bridge for the app start
extension API; it is inert (returns NoOpSpan / no-ops) until the Android
implementation and public Sentry facade land later in the stack.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Annotate NoOpAppStartExtender internal and fix test name typo
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename finishAppStart to finishExtendedAppStart
Mirrors sentry-cocoa's finishExtendedAppLaunch() and makes the API name explicit
about finishing the *extended* app start. Renames IAppStartExtender.finishAppStart()
and the NoOpAppStartExtender implementation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from getExtendedAppStartSpan when inactive
Mirrors Sentry.getSpan(): the extender reports null when there is no active extended span instead of a NoOpSpan, so callers can tell there is no span running.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Remove NoOpAppStartExtenderTest per PR review
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(extend-app-start): Guard setAppStartExtender against null
Match the NoOp-fallback convention used by other SentryOptions setters:
accept a @nullable argument and coalesce to NoOpAppStartExtender so the
@NotNull field and getter can never be nulled out.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Use setter method for appStartExtender
The @nullable setter and @NotNull getter no longer form a Kotlin
mutable property, so use setAppStartExtender(...) instead of the
property-assignment syntax (matches setTransportFactory/setReplayController).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat(extend-app-start): [2/4] Extract AppStartExtension component (#5606)
* feat(extend-app-start): Add IAppStartExtender bridge and SentryOptions wiring
Introduces the @ApiStatus.Internal IAppStartExtender contract (extendAppStart /
finishAppStart / getExtendedAppStartSpan) and a NoOp default, wired into
SentryOptions. This is the naming-stable core bridge for the app start
extension API; it is inert (returns NoOpSpan / no-ops) until the Android
implementation and public Sentry facade land later in the stack.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Annotate NoOpAppStartExtender internal and fix test name typo
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename finishAppStart to finishExtendedAppStart
Mirrors sentry-cocoa's finishExtendedAppLaunch() and makes the API name explicit
about finishing the *extended* app start. Renames IAppStartExtender.finishAppStart()
and the NoOpAppStartExtender implementation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Extract AppStartExtension component for the Android extender
Replaces the AppStartMetrics IAppStartExtender implementation and the deferred
ExtendedAppStartSpan with a focused, lock-guarded AppStartExtension that owns the
eager App Start transaction and extended span. AppStartMetrics now only holds the
component and exposes isAppStartWindowOpen(). Inert until 3/4 registers the listener.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Inject logger into AppStartExtension instead of static scope lookup
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Return ExtendedAppStart from the listener instead of a callback
The listener now returns the created transaction+span (or null to decline)
rather than calling back into onExtended() while extendAppStart() holds the
lock. This removes the re-entrant lock acquisition and the A->B->A round trip,
collapsing two public methods into one linear flow.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Remove redundant comments and rename reset to clear
Drop comments that restate code or annotate omissions (region markers, getter
javadoc, the reset call-site comment, the ExtendedAppStart/isActive docs). Rename
AppStartExtension.reset() to clear() to match its owner AppStartMetrics.clear().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Inline the logger lookup instead of injecting it
The extension logs only two warnings, both on rare guard paths in extendAppStart().
Inline Sentry.getCurrentScopes().getOptions().getLogger() at those sites instead of
holding a logger field set at init, dropping the field, setLogger(), and the
AndroidOptionsInitializer wiring. extendAppStart() runs post-init, so the lookup
always yields the configured logger.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the class and listener javadocs on AppStartExtension
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Trim finishTransaction/getExtendedEndTime comments
Drop finishTransaction's javadoc (trivial body; it described caller context and
waitForChildren behavior configured elsewhere) and reduce getExtendedEndTime's
javadoc to a single inline note on the only non-obvious branch (deadline suppression).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename AppStartExtension.finishAppStart to finishExtendedAppStart
Implements the renamed IAppStartExtender.finishExtendedAppStart().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the redundant foreground-check comment on extendAppStart
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-value getAppStartExtension test and trim comments
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-op finishExtendedAppStart test
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Read the extended span finish date, not its finished flag
getExtendedEndTime() gated on span.isFinished(), but finishing the extended
span completes the waitForChildren transaction and runs the event processor
re-entrantly within finishExtendedAppStart(), before the span's finished flag
is set. The processor then saw an unfinished span and dropped the app start
measurement whenever the extension finished after the first frame. Read
getFinishDate() (set before the finish callback) instead, which also keeps the
extended end controllable in tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): End the extended transaction at the extended span end
When the extended span finished after the timestamp passed to
finishTransaction() but before that call ran (e.g. a synchronous extension in a
headless start, where finishTransaction runs later at main-thread idle),
waitForChildren had nothing left to wait for and the transaction kept the
earlier passed timestamp. The extended span then ended after the transaction,
and the app start vital exceeded the transaction duration. Finish at
max(endTimestamp, extended span finish date) so the span is contained and the
duration matches the vital.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Guard extendAppStartListener with the lock
The setter wrote the field without synchronization while extendAppStart()
reads it under the lock, leaving no happens-before edge. Acquire the same
lock in the setter, consistent with the rest of the class's mutable state.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim verbose finishTransaction comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Read finish date in getExtendedAppStartSpan
Finishing the extended span runs the event processor re-entrantly (via
the waitForChildren transaction) before the span's isFinished() flag is
set, while the finish timestamp is already in place. Reading isFinished()
could therefore hand out a span that is already finishing. Switch to
getFinishDate() == null, matching getExtendedEndTime().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim duplicated reentrancy comment in getExtendedAppStartSpan
Replace the repeated reentrancy explanation with a cross-reference to
getExtendedEndTime(), which holds the canonical version.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Keep trimmed reentrancy comment within line length
Single-line form fits the 100-char limit so spotless leaves it unwrapped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Reword getExtendedAppStartSpan reentrancy comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename isAppStartWindowOpen to canExtendAppStart
The predicate has a single consumer — the extend gate in
AppStartExtension — so name it for that intent. Also drop the
self-evident max-end comment in finishTransaction. Regenerated apiDump.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop redundant getExtendedAppStartSpan finished test
After getExtendedAppStartSpan switched to getFinishDate(), the
"after the span finished" case exercises the same branch as the
reentrancy test (finishDate set -> NoOp); the isFinished stub was inert.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Add setData and isExtended to AppStartExtension
Move these component accessors into the component-extraction PR (they were
introduced later in the wiring PR). Keeps the full AppStartExtension surface
and its unit tests together here; the wiring PR only consumes them. Inert on
its own. Regenerated apiDump.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Make shouldSendStartMeasurements volatile
It is written without a lock in onAppStartSpansSent() and read across threads in canExtendAppStart() (via extendAppStart()), with no happens-before edge. volatile guarantees visibility, matching the AtomicInteger/AtomicBoolean siblings in the same check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(extend-app-start): Explain why AppStartExtension holds span and transaction
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from getExtendedAppStartSpan when inactive
Mirrors Sentry.getSpan(): the extender reports null when there is no active extended span instead of a NoOpSpan, so callers can tell there is no span running.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from AppStartExtension.getExtendedAppStartSpan when inactive
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Use setter method for appStartExtender
The @nullable setter and @NotNull getter no longer form a Kotlin
mutable property, so use setAppStartExtender(...) instead of the
property-assignment syntax (matches setTransportFactory/setReplayController).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): [3/4] Eagerly create the extended app start transaction (#5608)
* feat(extend-app-start): Add IAppStartExtender bridge and SentryOptions wiring
Introduces the @ApiStatus.Internal IAppStartExtender contract (extendAppStart /
finishAppStart / getExtendedAppStartSpan) and a NoOp default, wired into
SentryOptions. This is the naming-stable core bridge for the app start
extension API; it is inert (returns NoOpSpan / no-ops) until the Android
implementation and public Sentry facade land later in the stack.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Annotate NoOpAppStartExtender internal and fix test name typo
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename finishAppStart to finishExtendedAppStart
Mirrors sentry-cocoa's finishExtendedAppLaunch() and makes the API name explicit
about finishing the *extended* app start. Renames IAppStartExtender.finishAppStart()
and the NoOpAppStartExtender implementation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Extract AppStartExtension component for the Android extender
Replaces the AppStartMetrics IAppStartExtender implementation and the deferred
ExtendedAppStartSpan with a focused, lock-guarded AppStartExtension that owns the
eager App Start transaction and extended span. AppStartMetrics now only holds the
component and exposes isAppStartWindowOpen(). Inert until 3/4 registers the listener.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Inject logger into AppStartExtension instead of static scope lookup
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Return ExtendedAppStart from the listener instead of a callback
The listener now returns the created transaction+span (or null to decline)
rather than calling back into onExtended() while extendAppStart() holds the
lock. This removes the re-entrant lock acquisition and the A->B->A round trip,
collapsing two public methods into one linear flow.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Remove redundant comments and rename reset to clear
Drop comments that restate code or annotate omissions (region markers, getter
javadoc, the reset call-site comment, the ExtendedAppStart/isActive docs). Rename
AppStartExtension.reset() to clear() to match its owner AppStartMetrics.clear().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Inline the logger lookup instead of injecting it
The extension logs only two warnings, both on rare guard paths in extendAppStart().
Inline Sentry.getCurrentScopes().getOptions().getLogger() at those sites instead of
holding a logger field set at init, dropping the field, setLogger(), and the
AndroidOptionsInitializer wiring. extendAppStart() runs post-init, so the lookup
always yields the configured logger.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the class and listener javadocs on AppStartExtension
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Trim finishTransaction/getExtendedEndTime comments
Drop finishTransaction's javadoc (trivial body; it described caller context and
waitForChildren behavior configured elsewhere) and reduce getExtendedEndTime's
javadoc to a single inline note on the only non-obvious branch (deadline suppression).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename AppStartExtension.finishAppStart to finishExtendedAppStart
Implements the renamed IAppStartExtender.finishExtendedAppStart().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Eagerly create the extended App Start transaction (standalone-only)
Registers an extend-listener on AppStartExtension that eagerly creates the
standalone app.start transaction + extended child span in Application.onCreate,
held open via waitForChildren until Sentry.finishAppStart() or the deadline. The
first activity continues the eager trace into ui.load (attaching the screen so it
stays a foreground app.start) instead of creating a second app.start; headless
finishes the eager txn. The app start vital is max(natural, extended) so an early
finish never shortens it, and is suppressed on deadline. Standalone-only.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the redundant foreground-check comment on extendAppStart
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Replace the no-op finish test with isExtended coverage
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-value getAppStartExtension test and trim comments
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the redundant foreground-check comment on extendAppStart
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-value getAppStartExtension test and trim comments
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-op finishExtendedAppStart test
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Trim and de-duplicate comments in the eager app start path
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Clarify the extensionActive comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Read the extended span finish date, not its finished flag
getExtendedEndTime() gated on span.isFinished(), but finishing the extended
span completes the waitForChildren transaction and runs the event processor
re-entrantly within finishExtendedAppStart(), before the span's finished flag
is set. The processor then saw an unfinished span and dropped the app start
measurement whenever the extension finished after the first frame. Read
getFinishDate() (set before the finish callback) instead, which also keeps the
extended end controllable in tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): End the extended transaction at the extended span end
When the extended span finished after the timestamp passed to
finishTransaction() but before that call ran (e.g. a synchronous extension in a
headless start, where finishTransaction runs later at main-thread idle),
waitForChildren had nothing left to wait for and the transaction kept the
earlier passed timestamp. The extended span then ended after the transaction,
and the app start vital exceeded the transaction duration. Finish at
max(endTimestamp, extended span finish date) so the span is contained and the
duration matches the vital.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* ref(extend-app-start): Rename extended app start span op to app.start.extended
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Guard extendAppStartListener with the lock
The setter wrote the field without synchronization while extendAppStart()
reads it under the lock, leaving no happens-before edge. Acquire the same
lock in the setter, consistent with the rest of the class's mutable state.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Fix headless app start end time and duplicate txn
Two issues in onHeadlessAppStart for extended starts:
- The extended branch finished the eager transaction but never persisted
appStartEndTime, leaving the continuation window unbounded so a later
activity would wrongly continue the stale trace. Persist it on all paths.
- The branch only checked isActive(), so if the extension already finished
(finishExtendedAppStart or the deadline) before the headless idle ran, a
second, empty standalone app.start was created. Guard on
shouldSendStartMeasurements to avoid the duplicate.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim low-value comments in the headless fix
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Drop redundant extend-listener comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim redundant comments in onActivityCreated
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Remove explanatory comments in app start paths
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Consume stored app start trace on the extension path
The first activity continuing an extended app.start did not clear the stored
trace headers (only the headless-follow path did), so a later activity saw
them and wrongly reused the finished app start trace. Clear them on the
extension path too.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Only the launch activity attaches the app start screen
While the extension was open, every activity's onActivityCreated re-attached
app.vitals.start.screen to the eager app.start, so a second activity opened
before finishExtendedAppStart() overwrote the launch screen. Gate the attach
on isAppStart so only the launch activity sets it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Format code
* style(extend-app-start): Trim verbose finishTransaction comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim verbose comments in app start paths
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Read finish date in getExtendedAppStartSpan
Finishing the extended span runs the event processor re-entrantly (via
the waitForChildren transaction) before the span's isFinished() flag is
set, while the finish timestamp is already in place. Reading isFinished()
could therefore hand out a span that is already finishing. Switch to
getFinishDate() == null, matching getExtendedEndTime().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim duplicated reentrancy comment in getExtendedAppStartSpan
Replace the repeated reentrancy explanation with a cross-reference to
getExtendedEndTime(), which holds the canonical version.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Keep trimmed reentrancy comment within line length
Single-line form fits the 100-char limit so spotless leaves it unwrapped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Drop two line-narrating test comments
Remove comments that restated the adjacent test code (the eager
extendAppStart call and the second-activity open).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Reword getExtendedAppStartSpan reentrancy comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename isAppStartWindowOpen to canExtendAppStart
The predicate has a single consumer — the extend gate in
AppStartExtension — so name it for that intent. Also drop the
self-evident max-end comment in finishTransaction. Regenerated apiDump.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop redundant getExtendedAppStartSpan finished test
After getExtendedAppStartSpan switched to getFinishDate(), the
"after the span finished" case exercises the same branch as the
reentrancy test (finishDate set -> NoOp); the isFinished stub was inert.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop narrating comments from app start tests
The test names describe the scenarios; the inline comments restated them.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Add setData and isExtended to AppStartExtension
Move these component accessors into the component-extraction PR (they were
introduced later in the wiring PR). Keeps the full AppStartExtension surface
and its unit tests together here; the wiring PR only consumes them. Inert on
its own. Regenerated apiDump.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Name app start branching booleans by intent
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Make shouldSendStartMeasurements volatile
It is written without a lock in onAppStartSpansSent() and read across threads in canExtendAppStart() (via extendAppStart()), with no happens-before edge. volatile guarantees visibility, matching the AtomicInteger/AtomicBoolean siblings in the same check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(extend-app-start): Explain why AppStartExtension holds span and transaction
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from getExtendedAppStartSpan when inactive
Mirrors Sentry.getSpan(): the extender reports null when there is no active extended span instead of a NoOpSpan, so callers can tell there is no span running.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from AppStartExtension.getExtendedAppStartSpan when inactive
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Assert null extended span now that getExtendedAppStartSpan is nullable
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(extend-app-start): Explain single-use app start sampling decision
The get-then-clear of the app start sampling decision in
onExtendAppStartRequested looks redundant without context. Document
that the decision is pre-rolled on the previous run, forces the eager
app.start transaction's sampling and profiler binding, and must be
cleared so the first ui.load can't also claim it.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(extend-app-start): Bound the trace continuation window after an eager extension finishes
The eager extendAppStart path persists trace headers so a later
ui.load can continue the app.start trace, but never recorded the app
start end time - that was only set on the headless path. If the
extended transaction finished (user finish or deadline) before any
activity, the first ui.load treated the continuation window as
unbounded and joined the completed app-start trace no matter how much
later it started.
Persist the transaction's finish date via the transaction finished
callback, which covers every finish path (finishExtendedAppStart,
first frame, deadline), so the existing continuation window check
bounds the extend path the same way it bounds the headless one.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(extend-app-start): Skip warm-start reclassification while the extension is active
A first activity arriving more than a minute after launch resets the
app start span to the activity create time and flips the type to warm.
While an app start extension is active this corrupts the extended
vital: the eager app.start transaction stays anchored at process start
while the measurement subtracts the reset span start, and a cold
launch gets reported under the warm key.
An active extension is the user explicitly saying the launch is still
in progress, so let it pin the launch: skip the reclassification while
the extension is active and apply the heuristic as before once it has
finished.
Co-Authored-By: Claude <noreply@anthropic.com>
* test(extend-app-start): Remove NoOpAppStartExtenderTest per PR review
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
* feat(extend-app-start): [4/4] Add public Sentry app start extension API and update example app (#5628)
* feat(extend-app-start): Add IAppStartExtender bridge and SentryOptions wiring
Introduces the @ApiStatus.Internal IAppStartExtender contract (extendAppStart /
finishAppStart / getExtendedAppStartSpan) and a NoOp default, wired into
SentryOptions. This is the naming-stable core bridge for the app start
extension API; it is inert (returns NoOpSpan / no-ops) until the Android
implementation and public Sentry facade land later in the stack.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Annotate NoOpAppStartExtender internal and fix test name typo
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename finishAppStart to finishExtendedAppStart
Mirrors sentry-cocoa's finishExtendedAppLaunch() and makes the API name explicit
about finishing the *extended* app start. Renames IAppStartExtender.finishAppStart()
and the NoOpAppStartExtender implementation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Extract AppStartExtension component for the Android extender
Replaces the AppStartMetrics IAppStartExtender implementation and the deferred
ExtendedAppStartSpan with a focused, lock-guarded AppStartExtension that owns the
eager App Start transaction and extended span. AppStartMetrics now only holds the
component and exposes isAppStartWindowOpen(). Inert until 3/4 registers the listener.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Inject logger into AppStartExtension instead of static scope lookup
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Return ExtendedAppStart from the listener instead of a callback
The listener now returns the created transaction+span (or null to decline)
rather than calling back into onExtended() while extendAppStart() holds the
lock. This removes the re-entrant lock acquisition and the A->B->A round trip,
collapsing two public methods into one linear flow.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Remove redundant comments and rename reset to clear
Drop comments that restate code or annotate omissions (region markers, getter
javadoc, the reset call-site comment, the ExtendedAppStart/isActive docs). Rename
AppStartExtension.reset() to clear() to match its owner AppStartMetrics.clear().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Inline the logger lookup instead of injecting it
The extension logs only two warnings, both on rare guard paths in extendAppStart().
Inline Sentry.getCurrentScopes().getOptions().getLogger() at those sites instead of
holding a logger field set at init, dropping the field, setLogger(), and the
AndroidOptionsInitializer wiring. extendAppStart() runs post-init, so the lookup
always yields the configured logger.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the class and listener javadocs on AppStartExtension
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Trim finishTransaction/getExtendedEndTime comments
Drop finishTransaction's javadoc (trivial body; it described caller context and
waitForChildren behavior configured elsewhere) and reduce getExtendedEndTime's
javadoc to a single inline note on the only non-obvious branch (deadline suppression).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename AppStartExtension.finishAppStart to finishExtendedAppStart
Implements the renamed IAppStartExtender.finishExtendedAppStart().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Eagerly create the extended App Start transaction (standalone-only)
Registers an extend-listener on AppStartExtension that eagerly creates the
standalone app.start transaction + extended child span in Application.onCreate,
held open via waitForChildren until Sentry.finishAppStart() or the deadline. The
first activity continues the eager trace into ui.load (attaching the screen so it
stays a foreground app.start) instead of creating a second app.start; headless
finishes the eager txn. The app start vital is max(natural, extended) so an early
finish never shortens it, and is suppressed on deadline. Standalone-only.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Add public Sentry app start extension API
Static bridge delegating to options.getAppStartExtender(): extendAppStart(),
finishAppStart(), getExtendedAppStartSpan(). No-op when the SDK is disabled or the
platform provides no app start extender. Completes the extend app start feature (4/4).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the redundant foreground-check comment on extendAppStart
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Replace the no-op finish test with isExtended coverage
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-value getAppStartExtension test and trim comments
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Drop the redundant foreground-check comment on extendAppStart
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-value getAppStartExtension test and trim comments
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop the no-op finishExtendedAppStart test
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Trim and de-duplicate comments in the eager app start path
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(extend-app-start): Clarify the extensionActive comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Show extending the app start in the Android sample
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Read the extended span finish date, not its finished flag
getExtendedEndTime() gated on span.isFinished(), but finishing the extended
span completes the waitForChildren transaction and runs the event processor
re-entrantly within finishExtendedAppStart(), before the span's finished flag
is set. The processor then saw an unfinished span and dropped the app start
measurement whenever the extension finished after the first frame. Read
getFinishDate() (set before the finish callback) instead, which also keeps the
extended end controllable in tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): End the extended transaction at the extended span end
When the extended span finished after the timestamp passed to
finishTransaction() but before that call ran (e.g. a synchronous extension in a
headless start, where finishTransaction runs later at main-thread idle),
waitForChildren had nothing left to wait for and the transaction kept the
earlier passed timestamp. The extended span then ended after the transaction,
and the app start vital exceeded the transaction duration. Finish at
max(endTimestamp, extended span finish date) so the span is contained and the
duration matches the vital.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* ref(extend-app-start): Rename extended app start span op to app.start.extended
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Guard extendAppStartListener with the lock
The setter wrote the field without synchronization while extendAppStart()
reads it under the lock, leaving no happens-before edge. Acquire the same
lock in the setter, consistent with the rest of the class's mutable state.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Fix headless app start end time and duplicate txn
Two issues in onHeadlessAppStart for extended starts:
- The extended branch finished the eager transaction but never persisted
appStartEndTime, leaving the continuation window unbounded so a later
activity would wrongly continue the stale trace. Persist it on all paths.
- The branch only checked isActive(), so if the extension already finished
(finishExtendedAppStart or the deadline) before the headless idle ran, a
second, empty standalone app.start was created. Guard on
shouldSendStartMeasurements to avoid the duplicate.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim low-value comments in the headless fix
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Drop redundant extend-listener comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim redundant comments in onActivityCreated
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Remove explanatory comments in app start paths
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Consume stored app start trace on the extension path
The first activity continuing an extended app.start did not clear the stored
trace headers (only the headless-follow path did), so a later activity saw
them and wrongly reused the finished app start trace. Clear them on the
extension path too.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Only the launch activity attaches the app start screen
While the extension was open, every activity's onActivityCreated re-attached
app.vitals.start.screen to the eager app.start, so a second activity opened
before finishExtendedAppStart() overwrote the launch screen. Gate the attach
on isAppStart so only the launch activity sets it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Format code
* Format code
* style(extend-app-start): Trim verbose finishTransaction comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim verbose comments in app start paths
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Read finish date in getExtendedAppStartSpan
Finishing the extended span runs the event processor re-entrantly (via
the waitForChildren transaction) before the span's isFinished() flag is
set, while the finish timestamp is already in place. Reading isFinished()
could therefore hand out a span that is already finishing. Switch to
getFinishDate() == null, matching getExtendedEndTime().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Trim duplicated reentrancy comment in getExtendedAppStartSpan
Replace the repeated reentrancy explanation with a cross-reference to
getExtendedEndTime(), which holds the canonical version.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Keep trimmed reentrancy comment within line length
Single-line form fits the 100-char limit so spotless leaves it unwrapped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Drop two line-narrating test comments
Remove comments that restated the adjacent test code (the eager
extendAppStart call and the second-activity open).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(extend-app-start): Reword getExtendedAppStartSpan reentrancy comment
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Rename isAppStartWindowOpen to canExtendAppStart
The predicate has a single consumer — the extend gate in
AppStartExtension — so name it for that intent. Also drop the
self-evident max-end comment in finishTransaction. Regenerated apiDump.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop redundant getExtendedAppStartSpan finished test
After getExtendedAppStartSpan switched to getFinishDate(), the
"after the span finished" case exercises the same branch as the
reentrancy test (finishDate set -> NoOp); the isFinished stub was inert.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Drop narrating comments from app start tests
The test names describe the scenarios; the inline comments restated them.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Add setData and isExtended to AppStartExtension
Move these component accessors into the component-extraction PR (they were
introduced later in the wiring PR). Keeps the full AppStartExtension surface
and its unit tests together here; the wiring PR only consumes them. Inert on
its own. Regenerated apiDump.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* refactor(extend-app-start): Name app start branching booleans by intent
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(extend-app-start): Make shouldSendStartMeasurements volatile
It is written without a lock in onAppStartSpansSent() and read across threads in canExtendAppStart() (via extendAppStart()), with no happens-before edge. volatile guarantees visibility, matching the AtomicInteger/AtomicBoolean siblings in the same check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(extend-app-start): Explain why AppStartExtension holds span and transaction
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from getExtendedAppStartSpan when inactive
Mirrors Sentry.getSpan(): the extender reports null when there is no active extended span instead of a NoOpSpan, so callers can tell there is no span running.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Return null from AppStartExtension.getExtendedAppStartSpan when inactive
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(extend-app-start): Assert null extended span now that getExtendedAppStartSpan is nullable
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(extend-app-start): Make Sentry.getExtendedAppStartSpan() nullable
Mirrors Sentry.getSpan(): returns null when no extension is active instead of a NoOpSpan, so callers can tell there is no span running. Sample null-checks the span.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
* changelog
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
PR Stack (Extend App Start)
📜 Description
Registers the extend-listener and wires the extension through to the trace and the vital, making the feature work end-to-end. The extension is eager and standalone-only — only the standalone
app.starttransaction is independent of an activity and can be created inApplication.onCreate.ActivityLifecycleIntegrationenableStandaloneAppStartTracingis on (this is what makes the API standalone-only). OnSentry.extendAppStart()the listener eagerly creates the standaloneapp.starttransaction (waitForChildren+ deadline) and itsapp.start.extendedchild, and returns them as anExtendedAppStart.PerformanceAndroidEventProcessormax(natural first-frame duration, extended end), so an early finish never shortens it. On deadline the measurement is suppressed entirely (no inflated ~30s value); spans still attach. Non-extended starts are unchanged.Notes
appStartTransactionfield, so per-activity cleanup can't cancel it.ui.load(viaisActive()) instead of starting a secondapp.start, and attaches the screen so the foregroundapp.startkeeps itsapp.vitals.start.screen.waitForChildrenholds it open untilSentry.finishExtendedAppStart(). Headless finishes it at the headless stop time. A sharedcreateStandaloneAppStartTransaction(...)helper backs both paths.ui.load) extension path are removed — eager creation makes them unnecessary.💡 Motivation and Context
Part of the app start extension API stack (#5553). This is where the extension actually affects the trace and the vital, scoped to standalone app start tracing because only the standalone
app.starttransaction can be created eagerly inonCreate.💚 How did you test it?
Unit tests (TDD):
ActivityLifecycleIntegrationTest— eagerapp.start+ extended child on extend; first activity continues the trace with no secondapp.startand the screen attached; standalone & headless stay open untilfinishExtendedAppStart(); standalone-off is a no-op; the eager txn survives activity destroy.PerformanceAndroidEventProcessorTest— extended end drives the cold measurement; an early finish never reports shorter than the first-frame duration; a deadline finish suppresses the measurement.apiCheck, spotless, and the:sentry-android-coreunit suite pass.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
[4/4]— add the publicSentry.extendAppStart()/Sentry.finishExtendedAppStart()/Sentry.getExtendedAppStartSpan()facade.#skip-changelog