Skip to content

test: Update examples to Forge 8 and @sentry/bundler-plugins - #1478

Merged
timfish merged 6 commits into
masterfrom
tim/update-examples
Oct 22, 2026
Merged

timfish merged 6 commits into
masterfrom
tim/update-examples

Conversation

@timfish

@timfish timfish commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator
  • Update electron-forge, electron-forge-vite and electron-forge-webpack to Electron Forge 8
  • Point Forge examples at the new .cjs main entry paths that Forge 8 emits
  • Replace @sentry/webpack-plugin and @sentry/vite-plugin with @sentry/bundler-plugins/webpack and @sentry/bundler-plugins/vite
  • Pin @sentry/bundler-plugins to the JS SDK version in the e2e test setup
  • Update webpack-context-isolation examples to webpack-cli 7
  • Update electron-vite example to electron-vite 5, Vite 7 and Vue 3.5
  • Bump @sentry/electron and electron versions in all examples

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1dc5a58. Configure here.

"description": "Electron Forge Webpack example",
"version": "1.0.0",
"main": ".webpack/main",
"main": ".webpack/main/index.cjs",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong webpack Forge main entry

High Severity

The webpack example now points main at index.cjs, but Forge 8's webpack plugin still writes index.js under .webpack/main. Electron cannot load that missing file, so packaging and the e2e run fail. The .cjs output change applies to the Vite plugin, not webpack.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1dc5a58. Configure here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forge 8's webpack plugin emits .webpack/main/index.cjs. With .webpack/main, the build fails with an error naming that path. The e2e test passes with this change.

@timfish
timfish requested review from JPeer264 and Lms24 October 22, 2026 11:04
@timfish
timfish merged commit d4abdba into master Oct 22, 2026
115 checks passed
@timfish
timfish deleted the tim/update-examples branch October 22, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants