Repository navigation
fix(v7): Only add main process context lines to renderer frames in the app directory - #1475
Merged
Merged
Conversation
…p directory Renderer stack frames mostly hold renderer URLs. Preload script frames are files in the app directory and keep their main process context lines. Renderer frames outside the app directory get none.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
JPeer264
approved these changes
Oct 19, 2026
|
|
||
| const result = await wrapped.processEvent?.(event, {}, {} as never); | ||
|
|
||
| expect(wrapped).not.toBe(integration); |
Member
There was a problem hiding this comment.
That line is new, is that expected?
Collaborator
Author
There was a problem hiding this comment.
Good, spot. Not meant to be here!
Member
There was a problem hiding this comment.
haha, just wanted to post a meme - but the comment is gone :P
timfish
force-pushed
the
ccr-6ee1cfbd-3n8uz3-v7
branch
from
October 19, 2026 16:33
b66fc10 to
3950467
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1469 to v7.
Renderer stack frames mostly hold renderer URLs, which the main process
ContextLinesintegration cannot resolve. Preload script frames are the exception: they are files in the app directory, and the main process adds context lines to them.This marks events from renderers in
sdkProcessingMetadataand wraps theContextLinesintegration. For renderer events, it only adds context lines to frames whose file is insideapp.getAppPath(). Main process and utility process events are not changed. The wrapper also applies when users addcontextLinesIntegrationthemselves.The marker uses
sdkProcessingMetadata, so it is not sent to Sentry.